From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbdKVGIu (ORCPT ); Wed, 22 Nov 2017 01:08:50 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54396 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbdKVGIs (ORCPT ); Wed, 22 Nov 2017 01:08:48 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B86A460351 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function To: Sinan Kaya , linux-pci@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , open list References: <1511328675-21981-1-git-send-email-okaya@codeaurora.org> <1511328675-21981-31-git-send-email-okaya@codeaurora.org> <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org> From: Timur Tabi Message-ID: <25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org> Date: Wed, 22 Nov 2017 00:08:45 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/17 11:55 PM, Sinan Kaya wrote: > For places where domain number information is available, I extracted domain number > and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers. My suggestion is that you restrict your first patch set to only these patches. > The assumption at this point is for pci_get_bus_and_slot() usages to be caught > in code-review. How about this: static inline struct pci_dev * __deprecated pci_get_bus_and_slot(unsigned int bus, unsigned int devfn) { return pci_get_domain_bus_and_slot(0, bus, devfn); } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.