From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from polaris.svanheule.net (polaris.svanheule.net [84.16.241.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0D438BDAB for ; Thu, 22 Jan 2026 19:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.241.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769108414; cv=none; b=aHkSuc1imrt5+pUsullwsi3sdM1SfoV3gu/kIN9/Ac64iqEoREtZTrGos9KUlzN0WBN2ukGCedBV1qqJQZFaROgXYNw/idIZH/J7c0WdqE95nUFHcqWhVj35cKnm5OU9iN8znNKIs5HWic5DicGT4uZBmugmj2+pobV6Lird7Wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769108414; c=relaxed/simple; bh=swrlHPUBKtlnhMtciE5+QOaGnR0HJsJDWjwTDiXUfRA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=DP5o9NiOapg0KG23ppw4+goGxUA3KMPKGfGBnQtF/OiltKXHFsQtlMpvyxHeS4/NXisygaJYIuGS3U9+qB+M2o0HbRicqiNmPZt/sXfJq793+RnR/zW0eM8kJTv7ipWV48Ujm+7/Aa1D7RbCEMb8TkVuiBLlapSnLWyjm5HIurY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svanheule.net; spf=pass smtp.mailfrom=svanheule.net; dkim=pass (2048-bit key) header.d=svanheule.net header.i=@svanheule.net header.b=scWXGvmN; arc=none smtp.client-ip=84.16.241.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svanheule.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=svanheule.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=svanheule.net header.i=@svanheule.net header.b="scWXGvmN" Received: from [IPv6:2a02:1812:162c:8f00:19d9:5e35:1cd7:5d5d] (2a02-1812-162c-8f00-19d9-5e35-1cd7-5d5d.ip6.access.telenet.be [IPv6:2a02:1812:162c:8f00:19d9:5e35:1cd7:5d5d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id AD3656CF57C; Thu, 22 Jan 2026 19:52:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1769107980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XN4B5DCK0dBB222GFaDnpJxzaLb0lnsfXuQUUNsyrak=; b=scWXGvmNainY1kQ77gLARjznXHp6TO+wM6m+tn1/+83ESV/HT6d1twjbe2ueHYcn1LskEI zCr4pexsV9ktEqIDhFMO2pRHYvqeI7AHUV7/yHj+EkGt2iP49UTW/3ueGTDHwboGX3dvSZ h14cTdHbs8+iEL5vkbS2Z80FBJK2hYZ/UMIhrYxEBV9i2JMKWw7pzbF2wFBU4hBbfE8M9x AstzPZbmUZjsJWC48dlWh1KuePneV3+CR4beym6x8oIAxl+pXz+0lc6YdJEt/hKuVdTMmL PF4hyJpcpvSr/gPWmCLK6jCr4eOBp4C4GPP+C3WgHnHGgI2ru28Cs7B8/8OaHQ== Message-ID: <25fb1bb85424e9d27348a51ce5bb1fe727d363ed.camel@svanheule.net> Subject: Re: [PATCH v8 02/10] mfd: nxp-siul2: add support for NXP SIUL2 From: Sander Vanheule To: Khristine Andreea Barbulescu , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Larisa Grigore , Lee Jones , Shawn Guo , Sascha Hauer , Fabio Estevam , Dong Aisheng , Jacky Bai , Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Alberto Ruiz , Christophe Lizzi , devicetree@vger.kernel.org, Enric Balletbo , Eric Chanudet , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, NXP S32 Linux Team , Pengutronix Kernel Team , Vincent Guittot Date: Thu, 22 Jan 2026 19:52:57 +0100 In-Reply-To: <20260120115923.3463866-3-khristineandreea.barbulescu@oss.nxp.com> References: <20260120115923.3463866-1-khristineandreea.barbulescu@oss.nxp.com> <20260120115923.3463866-3-khristineandreea.barbulescu@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Khristine, On Tue, 2026-01-20 at 13:59 +0200, Khristine Andreea Barbulescu wrote: > +static const struct regmap_config nxp_siul2_regmap_pgpdo_conf =3D { > + .val_bits =3D 16, > + .val_format_endian =3D REGMAP_ENDIAN_LITTLE, > + .reg_bits =3D 32, > + .reg_stride =3D 2, > + .cache_type =3D REGCACHE_FLAT, > + .use_raw_spinlock =3D true, > +}; I see you are using REGCACHE_FLAT ... > + if (tmp_conf.cache_type !=3D REGCACHE_NONE) > + tmp_conf.num_reg_defaults_raw =3D > + 1 + tmp_conf.max_register / > tmp_conf.reg_stride; ... and initialize the cache defaults from hardware. This series predates the addition of REGCACHE_FLAT_S in v6.19 with commit 9c7f7262bc1a ("regmap: add flat cache with sparse validity"), but I think switching to the sparse flat cache would allow you to drop this. Then the c= ache will just be initialized on the first hardware access instead of at regmap = init. Best, Sander