From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1905A225397 for ; Thu, 5 Feb 2026 13:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770298718; cv=none; b=HJSiG9D7OgY/uL9riHDvSARz+LwqWnQ0AfopID59SzWxh26+thomASF5IHTTw7kqn/81YTJije0FrXJtmfQp29HgvlVRpV00qRdOz21TM2z6V+FUuNzRRFcLSvN191xxXdaXxgsiE1nJmHK5di2TTCOAibEQF6FuZXWrbDTC55A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770298718; c=relaxed/simple; bh=Z6L3fl09q9kSrubjFQ88R/6yrh72aTeNMdVC+nRTLfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rpSm00NP66If3mldHI36XR24R4K/lzcpjG27IL2DqytQev3PSy/8schD15DmKS5YeQZiN82OMZkhedwCUl3FsEzQFkVo6nbO48X4Mwp5Bk5pJiuBEePJ+0bG3L/O/DL1fmUbECADnWwdkx6PRXyx1Yk4mlJUrFTVa6HdgGB89K8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=xs+IQunU; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="xs+IQunU" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43596062728so1476919f8f.1 for ; Thu, 05 Feb 2026 05:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1770298716; x=1770903516; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=02iWfztf973elI54X0voRTm4GyeDYKJI/pJtF0EYb1U=; b=xs+IQunUW0ewWnaS/QzrLa7nEmdLnPA75CewTe7vq5eNs6GBj1hpb+KlPPuE3kKcA4 TO8Kl0YJrMcPS34PymPDjU7QieDqRlaOCLb9uEpSSxLGegVfd6HQOgtAW4TOM76P9eih bZRbjdKe1Cd6VGwRkEvPpIr1apgRP0ytNeJxBZVeRdB5pq2yzJKW7W84fZ1VRIj0cQ36 vm7nYTaKgRli6iVpUx66ZZtQ9tm2tLICW2HXTtE1wVL2uuyvvt3lXwORDQnaIAHKT4y7 oUE6pHxIEqdWZS5hRXJJgDgA5joyFvfoohFPOl1l9xPv6Ml62s7c5/r8rYBjLBN7Evwp wN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770298716; x=1770903516; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=02iWfztf973elI54X0voRTm4GyeDYKJI/pJtF0EYb1U=; b=qM37f983iHLF+LmYs54um/pKWSqiu0IZGrcGxlU1U5nhD7UcI9rkt3vNzYoUyBqE+R QnDKzd0I43feddhvVRdkb3Ra4uDcKihBslsCskYJD0YRWfwre58xCvsvYO0ur8PDZ8DB RIAQo/5K78KV50kLTu3/rGbC95RbYxGQ3k399dGvIOqTe7M0tGGuJnwYYJqdb4xHbZw/ M2J06Sm/iEmSTwbS4IdfEPjgE+S30GNqW5BZRChuXgWaiOKp+iQGJ4Ew5PubMW45fJbh GpdEnwLqB25Ix1nOyrOFw1dtGmeLwp1DoeVD660eCKDXPeSuzEAD98+xis1jNO+V3Bd1 yTJg== X-Forwarded-Encrypted: i=1; AJvYcCWvsK8dnna90zoc46n4ryGQkjzSZV9b5re8ahw11TLOs5fKLfsO+IbmKUYXKKQkr563PpVV8IxCmOOSNog=@vger.kernel.org X-Gm-Message-State: AOJu0YxgUr9reVxGMIit7PITt6UO+a7GQTBVACQQUo1aQDItOSBFBvd6 hCt0BH7WUieqH+VkkCzKu8SxpHpFGAmy4sr7jIZ+2jMoJ9aYHelz/i4MtQaOL7oEOZo= X-Gm-Gg: AZuq6aLUgVNIrxLhAxgEoOtKdngXLLtl1YLMO78BBf4aELPFF1sZPcQgUhYfxVGLQ/P TBwWTbDUup5NWL+KKSxVSSdEC9NLGekK3n/z42eRRXhYWhXfENNow4Z6D2wcz8TGaTebqLgx5Ts K8S4Tsz95YOunouM1uu5ibBd8X6j4He50Wuoz+rPofhjNw2j1gaZ3LJ4tyBAw3SIhFfT1d/kX0W P3cKan1bwC5L+1CK44HOtrpoOKg8q4GtwoUn+liSrYRY55aIP5V1RFphgvO7j8tm0hjp8O25Fy5 vz+jFgkJyhbcLBeApwBLGikD4BUGluQGDPwf5ijiRMKx5mFPDWRTLgYsl5gkqwLjopOPJ4d6bYd AjzLPaRhJtd64iSt+A0ckiuIMp1nsBvpOZONg1DoNjuBw//ox8X58yvyZ6+03ef1AO2DkCOiDsO VCPTEZ1cuasjc7HUEOVr9sA/PenbztKnV2DBiju3aw/srB55E= X-Received: by 2002:a05:6000:2887:b0:425:86da:325f with SMTP id ffacd0b85a97d-436213eb7d6mr4362010f8f.27.1770298716349; Thu, 05 Feb 2026 05:38:36 -0800 (PST) Received: from ?IPV6:2a02:810a:b98:a000::b3d5? ([2a02:810a:b98:a000::b3d5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e38fbbsm14752532f8f.13.2026.02.05.05.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 05:38:35 -0800 (PST) Message-ID: <25ff0841-545b-433a-8e88-6e463ea718e7@cogentembedded.com> Date: Thu, 5 Feb 2026 14:38:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: renesas: rswitch: fix forwarding offload statemachine To: Michael Dege , Yoshihiro Shimoda , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260205-fix-offloading-statemachine-v1-1-640224a531d0@renesas.com> <3b1405cd-6c7f-4883-95fb-151cab223a68@cogentembedded.com> Content-Language: en-US, ru-RU From: Nikita Yushchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>> if (rdev_for_l2_offload() && rdev->forwarding_requested) >>>     rswitch_change_l2_hw_offloading(rdev, true, false); else >>>     rswitch_change_l2_hw_offloading(rdev, false, false); >>> >>> since rswitch_change_l2_hw_offloading() has internal check for the >>> current state and returns early if the requested change is already applied. > > Unfortunately, this has a side effect, e.g., if you pull the cable on tsn0 and the link > goes down, you will see that the offloading is disabled on all ports connected to the > bridge and not just on tsn0. Quite strange, is anything else logged? E.g. some messages from linux bridge layer? Nikita