From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DF7C433FE for ; Mon, 7 Dec 2020 01:11:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3486122CAE for ; Mon, 7 Dec 2020 01:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728606AbgLGBLY (ORCPT ); Sun, 6 Dec 2020 20:11:24 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9019 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgLGBLY (ORCPT ); Sun, 6 Dec 2020 20:11:24 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cq4x0351qzhn7d; Mon, 7 Dec 2020 09:10:12 +0800 (CST) Received: from [10.67.102.118] (10.67.102.118) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Dec 2020 09:10:37 +0800 Subject: Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930 To: Herbert Xu CC: , References: <1606357086-9785-1-git-send-email-liulongfang@huawei.com> <1606357086-9785-3-git-send-email-liulongfang@huawei.com> <20201204070359.GA26438@gondor.apana.org.au> From: liulongfang Message-ID: <26023bba-78cf-4d91-3510-b6d69fa4768e@huawei.com> Date: Mon, 7 Dec 2020 09:10:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20201204070359.GA26438@gondor.apana.org.au> Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.118] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/4 15:03, Herbert Xu Wrote: > On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote: >> >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> index 0e933e7..712176b 100644 >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h >> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h >> @@ -211,6 +219,167 @@ struct sec_sqe { >> struct sec_sqe_type2 type2; >> }; >> >> +#pragma pack(4) > > Please don't use pragma pack. Instead add the attributes as > needed to each struct or member. > > Cheers, > OK, I will modify it in next patchset thanks. Longfang