From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753319AbcGYTq4 (ORCPT ); Mon, 25 Jul 2016 15:46:56 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:47422 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753024AbcGYTqx (ORCPT ); Mon, 25 Jul 2016 15:46:53 -0400 Subject: Re: [PATCH 2/2] Input: cros_ec_keyb - Fix usage of cros_ec_cmd_xfer() To: Brian Norris , Lee Jones , Thierry Reding , Wolfram Sang , Dmitry Torokhov References: <1469470451-111822-1-git-send-email-briannorris@chromium.org> <1469470451-111822-3-git-send-email-briannorris@chromium.org> Cc: Olof Johansson , Brian Norris , Enric Balletbo , Shawn Nematbakhsh , Gwendal Grignou , Tomeu Vizoso , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Guenter Roeck From: Javier Martinez Canillas Message-ID: <2607f36e-ee56-98c8-ba7d-ec44a34dd512@osg.samsung.com> Date: Mon, 25 Jul 2016 15:46:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1469470451-111822-3-git-send-email-briannorris@chromium.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Brian, On 07/25/2016 02:14 PM, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors and operating on uninitialized data. > > We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these > problems. Let's use it. > > Signed-off-by: Brian Norris > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America