From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbdDJUUz (ORCPT ); Mon, 10 Apr 2017 16:20:55 -0400 Received: from mout.web.de ([212.227.17.12]:59921 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbdDJUUx (ORCPT ); Mon, 10 Apr 2017 16:20:53 -0400 Subject: [PATCH 3/3] thermal: int340x: Use kcalloc() in int340x_thermal_zone_add() From: SF Markus Elfring To: linux-pm@vger.kernel.org, Eduardo Valentin , Srinivas Pandruvada , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org References: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Message-ID: <26087e0f-74a0-3eb1-7e54-2dafe45d633f@users.sourceforge.net> Date: Mon, 10 Apr 2017 22:20:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <3ba36cc1-8445-462c-ca75-2b0928f3290a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Z7reCNJnKLz1d//LyPiSKZukzKc3ZboQAcUWrIrxvXVeJ7+4Rs+ TWo/mZLaS5aLtLH5eTRcIOt/F1Lj06cTGTUTH30AV5lstAyxdxgpW00Z9X4jr7naEpuE7h1 Al3sYTgUy/jZQNHHs8oimEaxu7eB+2+LzB1kohgMGWmKzF0TPT234eHNl3+yjCBfFOGOt+D 7yTNl5sZQjDjUbRGCgKYQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:P4YOB36SjSU=:FHIaCAbtN0wk3xbCzbEEK6 6S+phDg2GjjfaRgtAEl7hCs2+cmr8smIIZ8xgfDyETgLf27xZ+CJkIh1mVGVibi4L+GB8d2ek YyxTm8dKD1L7Z4a920ai+cOHAmVz9RyI1GHW6ruSnjBuuREEohc7BnhQ9KNuU344m0U2gVAir PeCNpsQCAaVXGmDav4DZRLtec941OaJ3GxEOKAE1wPmpd8ZIoN8AG6l/K95fJm0Q5HGrWy8BU ylxduVa+XMhnB0IIU8wvcF5q6MyWUWZWbxsOBPVwl53xZ1tkORE3dTQhlqwFkR+dSSJfrBGHJ 3aMsg8GE6gJaqt+c7uMXF41UVbCqsZmL3p5qGVOyM4b0jqkqts0xiGZLBjrSqtRKeLPqENBym uqf8nX5bRR7iXTj99v0racoi0DWc49freoWjDKtEag6OkFFA49AzwXEd0MVcZ1Qi1LgAr9NTZ jpTMaN6TDsEN5zxkE1pI+euX6vMp/FOCmMFFmHHSPY6ZTVQYyFeTFBrEBGbqmvsIe9zXbkUMH lBo+vWR/7a2v1ei3avyz/Upnu2ykG4Our/Tpad9YtSPRqJnX8yVatPMZ7cDDJmUbjSJO5BqgN htfM/KKLuXTCLK+BxOi5EZGMp6HnIGHIkqblFzMQtB2G15+LolzRPP6zmaIWr8BIM5vMAlguW SDpw7Qo86JadoxvLUhc3fiXn0H2GXb5EVoXlfBxiMM5pvqoWz9o+naWJzbdzSsmj5W+GVgnd4 ih29MFMJDmk6xHmN1x9OoLIQpT3/8HtorJebUJkLLX6leSqosm4MJ9FBMM2iV3+/AnolCm2PR yaKtV/Y Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 10 Apr 2017 21:56:58 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/thermal/int340x_thermal/int340x_thermal_zone.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/int340x_thermal/int340x_thermal_zone.c b/drivers/thermal/int340x_thermal/int340x_thermal_zone.c index 145a5c53ff5c..a611f3367168 100644 --- a/drivers/thermal/int340x_thermal/int340x_thermal_zone.c +++ b/drivers/thermal/int340x_thermal/int340x_thermal_zone.c @@ -239,9 +239,10 @@ struct int34x_thermal_zone *int340x_thermal_zone_add(struct acpi_device *adev, if (ACPI_FAILURE(status)) trip_cnt = 0; else { - int34x_thermal_zone->aux_trips = kzalloc( - sizeof(*int34x_thermal_zone->aux_trips) * - trip_cnt, GFP_KERNEL); + int34x_thermal_zone->aux_trips + = kcalloc(trip_cnt, + sizeof(*int34x_thermal_zone->aux_trips), + GFP_KERNEL); if (!int34x_thermal_zone->aux_trips) { ret = -ENOMEM; goto err_trip_alloc; -- 2.12.2