mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Cc: andy@kernel.org, sakari.ailus@linux.intel.com,
	Hans de Goede <hdegoede@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] media: atomisp: Remove unused atomisp_compat_ioctl32() declaration
Date: Tue, 22 Apr 2025 11:04:13 +0300	[thread overview]
Message-ID: <260a005d-a1bb-48d7-89ec-ed1b6b151b4a@stanley.mountain> (raw)
In-Reply-To: <20250418071823.8756-2-hardevsinh.palaniya@siliconsignals.io>

On Fri, Apr 18, 2025 at 12:48:18PM +0530, Hardevsinh Palaniya wrote:
> Since its definition was deleted in a previous patch[1]
> and there are no remaining users of this function in
> the codebase.
> 
> Link[1]:https://lore.kernel.org/linux-media/20210614103409.3154127-7-arnd@kernel.org/

Instead of a link to lore it should be:

The atomisp_compat_ioctl32() function was deleted in commit b4c650f1af68
("media: atomisp: remove compat_ioctl32 code") so delete the declaration
from the header.

Please don't say "it's" to refer to something mentioned in the subject.
When people are writing commit messages they sometimes treat the subject
as the first sentence of the commit message but the subject and the body
of the commit message should make sense independently.  Look at the lore
link you posted above.  Can you even find the subject?  Most of the time
when people see a link to lore they'll just read the body of the email.

regards,
dan carpenter


  parent reply	other threads:[~2025-04-22  8:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  7:18 [PATCH 1/2] media: atomisp: Remove compat ioctl32 header file Hardevsinh Palaniya
2025-04-18  7:18 ` [PATCH 2/2] media: atomisp: Remove unused atomisp_compat_ioctl32() declaration Hardevsinh Palaniya
2025-04-19  4:58   ` Andy Shevchenko
2025-04-22  8:04   ` Dan Carpenter [this message]
2025-04-19  4:50 ` [PATCH 1/2] media: atomisp: Remove compat ioctl32 header file Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=260a005d-a1bb-48d7-89ec-ed1b6b151b4a@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hardevsinh.palaniya@siliconsignals.io \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®