From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932099AbcEBSmH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 May 2016 14:42:07 -0400
Received: from mout.kundenserver.de ([212.227.126.134]:54405 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755106AbcEBSlw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 May 2016 14:41:52 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Kamil Debski <k.debski@samsung.com>,
        Jeongtae Park <jtp.park@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>, linux-media@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] s5p-mfc: Don't try to put pm->clock if lookup failed
Date: Mon, 02 May 2016 20:41:11 +0200
Message-ID: <2610031.B6nN8fjXyO@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1462210075-5320-1-git-send-email-javier@osg.samsung.com>
References: <1462210075-5320-1-git-send-email-javier@osg.samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:0puEH6EYW50nxCHsWPeEePANntt6GrUIdIyaClq77hrOYaj62iu
 1KjBOACNPol6ZOx9Iucp8huH8+sHG2UNGcDaID5PUE8Q2X8/lQR/N6c3Ni2HjbWRtOlA0td
 fjuOcYNRr1vlKDSjRMPfxcsme6WF2RK2z0wNNGnynQzjrLc/eVPYNRNDDsi177aqREJV1B8
 V+7lk6gzsrAJ9Ucv78VuQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:n5OAg8ak+aY=:QCS1mK7fVPQcTI7q14slBT
 UPu9dqPwS1QsxaGRUiYVviOZQBp6W89GjdDS43WE1rdCvhYJHYNJvGbLKmUoDmLRlRHehE79z
 wy1PZvbSGDmdaTOr26XrI8jB45CBfxqzjAubdpEDovcM1Uo6+dUDoqb2gc8WgK8d28mETSHzm
 eb8fNOGDLumWrIE67hX0JlCs+QE5wN95jfiuOXpGuFBEpju3yOnFDT+znJQgovavOOnRE6HSs
 G0twGPdO1Eg6D2A0B/kqH7z6H7etb73aT/l6HSYgJrRwu7l5SbDApPpbR86GhFrh8vCye1ASl
 1rFEDkNj01DZ3pRByvdJwVbMOa0qQO8X1++j6ROIv0E+RzYyCBFisNh5eeW7UkQBC7au1mz0M
 tkZKAymjrYmPq2oO6ixePcZ7e69lLOHVUXe705dnj+WSStmnB4ySd/Pe4FiJ3cfrKvqr3GRlY
 81nlSYSIO00trybcnIDO7NCXeilyrwKIhEFL9krSG3V409VBt5N47YuWBxma2JQ1AWT5e+AM9
 RTU6LC3N0NA7ax5Qu4Yd2zsgdMAH78sUvw9MHxvQbkIhA18ZhhXXflwzlxiLRNZlTtQSaTkZ+
 jPNQkwpPmljdxP6QjhsfeEHRZ1jYKAr5gWUGVCxeZDuMK6ktT3fxFgbovIw0dSOEch7WceXGs
 xaUaA/P42vsBpz63PmgFQZHXO2+a5NxdjQcrCC1UrveLznl5w/8m7mOJ4ZA/7XlIzwsfPCNIA
 i8ot2B8H5xnFxPgm
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote:
> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the
> clock field can have a errno pointer value. But s5p_mfc_final_pm() only
> checks if .clock is not NULL before attempting to unprepare and put it.
> 
> This leads to the following warning in clk_put() due s5p_mfc_final_pm():
> 

Better assign the pointer to NULL in case of a non-fatal error
return code. That way, the reader doesn't have to wonder why you
have the IS_ERR_OR_NULL() check here.

	Arnd