From: David Laight <David.Laight@ACULAB.COM>
To: "'richard.gong@linux.intel.com'" <richard.gong@linux.intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "mdf@kernel.org" <mdf@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Gong <richard.gong@intel.com>
Subject: RE: [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version
Date: Tue, 30 Mar 2021 14:19:02 +0000 [thread overview]
Message-ID: <26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com> (raw)
In-Reply-To: <1617114785-22211-2-git-send-email-richard.gong@linux.intel.com>
From: richard.gong@linux.intel.com
> Sent: 30 March 2021 15:33
>
> Extend Intel service layer driver to get the firmware version running at
> FPGA device. Therefore FPGA manager driver, one of Intel service layer
> driver's client, can decide whether to handle the newly added bitstream
> authentication function based on the retrieved firmware version.
Using the version number to detect features is just plain wrong.
You should use something like a bitmap of supported features.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-03-30 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:33 [PATCH] A patch for Intel service layer driver richard.gong
2021-03-30 14:33 ` [PATCH] firmware: stratix10-svc: extend SVC driver to get the firmware version richard.gong
2021-03-30 14:19 ` David Laight [this message]
2021-03-30 16:02 ` Richard Gong
2021-03-30 16:15 ` Moritz Fischer
2021-03-30 17:36 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®