From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D01331ED5 for ; Sat, 25 Jul 2026 05:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784958096; cv=none; b=oDctq7i1DOuT4bnowhLY6Gi2M615I4QCCBiYdbpJIwUu4xDOsCccf2xd2DW5TavINB33T51CiEg+7nEsg7zaXfffPb5a/of9xtxZMlbWVq6xnPLXdIcmceAcGdxPuWJIpj7q1MFPpvd5jFGlfyGhhX7NGHExMNxTXWIoFIEyUOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784958096; c=relaxed/simple; bh=/RjlJI1tcU+fQgj2sW2Iofa6fH5Ee2zC3WdA1A2qVFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qCLHv+HAw4cGHosO8oLBopTBYiuW8kNltvpM0ijx9e+x1lM7P3KNZwF4OWab5P0jMWaw8LZC76CIb85G9xTvOvUhjNDEEX4xfiHD6hBYHpIiSncVVMgThyqhatB3tRAPYcRFkwD1JkBSi/Nu3gEkfoH2oxc0tcSdZetxFAboGjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FAUufZML; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FAUufZML" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5aeb99bc721so132281e87.1 for ; Fri, 24 Jul 2026 22:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784958092; x=1785562892; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=090uL/0+UckPvFSEk0Snf0xihVIwbpOzrvl2u/5Apcc=; b=FAUufZMLTDLvln9pl0TWcIQDgO5RxxfYh2ot6Su3DyAx3u8o4aYSleqjSe0RIAXHtv otJi8Y30uMMn3i+VXeKknf/4+dRIcN+kLCp9Ez6zb7qWwnduFfR7CyD1rruZq3qfuzrD aAdlx3bMnac0UcfEJqZoRajub9iidHzOoBPNOYNDPw5zGK9Fn/6VDbzy73EbYoIAYYXx ORRc1/1gKzAltIlC8xTdCs2aMEJlh6pvzQL5yAt/se4+VE88YuhEW8V8SkPQbIHrAQtc FV4pwaFLgwFh2PRke0/8o8iGga8w00O5B9rOGDqWMlMg5fbGNSV+KUSeoZKABy/bXyYs 7TRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784958092; x=1785562892; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=090uL/0+UckPvFSEk0Snf0xihVIwbpOzrvl2u/5Apcc=; b=M52e7MR6X0YIp0BoY2BYmUOC7Zn/d1fWME2zVTc2L5Vm+oVobmYkrKBthJuxVtxVJy EHwPfZsIYocubNR02V/59AIGUefcBA7JH/+1Qz5ge+iiSGaYU9NSPnms1+erQyIDiF40 puP7spW4c7NwSSS0u+SpwOV2cJwBx6hF1xPu1HVzjlorfx9vQ/BowniCvgnMdlyosKio jW4BKyq3ICyRNxpb1s4cc+3OiUfV/NuPzoigDu0TJzwfrQJoy01H2sbHiQF/LMbXPqgq DdGSxLycI7961aIZ5qF+q2SmzllJILld4b1ph7Zh87KHjb66gceOzAo3fF2Mzj2sLe1A QYmQ== X-Forwarded-Encrypted: i=1; AHgh+Ro3ChvbgHdWN9s5TsaBL22a2cjojysAtNBLHgO2tZa6+P5DMOPJUeZgk9cdHzNy3Nm2belt0PclAWASHSE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2BpQNHeKC6ERk1NkYkjSwE3meenb2unsyipCaINehE7kQrrQQ TElqNYWnCq9t/cvVwVcDRWWobWPLM4lS0FTAeJUGzN2C9VKLZG6g5iFOEuD85FCCGUo= X-Gm-Gg: AR+sD11jWhvhWKkY2aShG9iRTlXpRp1Y8YMRlkp2cOV6rhnNzTbUNUCZu3fclc6BX/2 DSSJsYTX7pd8bwT8/ftBv6hnNB231/Lit7h9j5C3/ycsZUCfl/SjFM2RGj/Pp6xe+TshMIwrlr1 fvtnClxPedUBelZxv0UVXQBu+DoNkd8DJduksyPs+e1ewWe9+vxM8MHdFMm/bcGsQqxm5LvpC7B f+RW2H4GEhhrvH+XXQFB5OU9azSkTnl0RfPiDAJbiw1v5r3OIYtbU9QmBfhGF3V13tgo1+0/0U6 JlrI4qkE/jttgXAUqftmTFqPho7d8dcFV02WJVIrozrOu4QGFJrG/IZzB8OehRBfC58UIsvgwSB QQoGHzTE01nq5npyjjJYj/to4MMKR9nt/cTosEiTfSzHX135FywhcZt+eJUC3yUQ0FEIORSn7pc ane5ijqdEEXRv41eBlrVABINSg0sMs2tl+elmTmXUndOFsOYSiw3EST2fB X-Received: by 2002:a05:6512:1591:b0:5b1:5b9e:8de7 with SMTP id 2adb3069b0e04-5b2c1afdec6mr98432e87.2.1784958092471; Fri, 24 Jul 2026 22:41:32 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2be1d8b21sm253424e87.44.2026.07.24.22.41.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 22:41:31 -0700 (PDT) Message-ID: <261a03cd-62f6-4ab8-956e-f5ae8969a978@linaro.org> Date: Sat, 25 Jul 2026 08:41:30 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" To: Andi Shyti , Loic Poulain Cc: Robert Foss , Wolfram Sang , Dmitry Baryshkov , Luca Weiss , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> <20260721-cci-clk-fix-v1-1-5eae78700da8@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/26 01:57, Andi Shyti wrote: > Hi Loic, > > On Tue, Jul 21, 2026 at 04:58:19PM +0200, Loic Poulain wrote: >> This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6. >> >> The cci_clk_rate field is needed to enforce the correct CCI clock rate >> at probe time. The hw_params timing values are in clock ticks and were >> calibrated for a specific frequency per hardware variant, so running at >> the wrong rate would violate I2C timing specifications. >> >> Signed-off-by: Loic Poulain > > Does this revert need a Fixes tag? I haven't seen very often > reverts with Fixes tag, but it makes sense if they need to be > backported. This revert commit does not need a Fixes tag, since there is no bug fixed by the revert commit, I believe. But perhaps a series of commits may need Fixes tags each, if the series is to be backported. > I'm going to take patch 1 and 2 already while we discuss patch 3 > separately, but please let me know first if you agree adding the > Fixes tag. > -- Best wishes, Vladimir