From: Johannes Berg <johannes@sipsolutions.net>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Arend van Spriel" <aspriel@gmail.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Michael Buesch" <m@bues.ch>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcma,ssb: simplify dependency handling for bcma and ssb drivers
Date: Mon, 18 Dec 2023 14:17:59 +0100 [thread overview]
Message-ID: <26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net> (raw)
In-Reply-To: <20231218115802.15859-1-lukas.bulwahn@gmail.com>
On Mon, 2023-12-18 at 12:58 +0100, Lukas Bulwahn wrote:
Dunno, I'm not super involved with this but ...
> +++ b/drivers/bcma/Kconfig
> @@ -1,12 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> -config BCMA_POSSIBLE
> - bool
> - depends on HAS_IOMEM && HAS_DMA
> - default y
> -
> menuconfig BCMA
> tristate "Broadcom specific AMBA"
> - depends on BCMA_POSSIBLE
> + depends on HAS_IOMEM && HAS_DMA
[...]
> config BRCMSMAC
> tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver"
> - depends on MAC80211
> - depends on BCMA_POSSIBLE
> + depends on HAS_IOMEM && HAS_DMA && MAC80211
> select BCMA
to me it kind of seems more obvious for example in this case to say
"depend on BCMA_POSSIBLE and select BCMA" rather than open-coding the
BCMA dependencies both here and in BCMA? Now granted, they're rather
unlikely to _change_, but it still seems more obvious?
johannes
next prev parent reply other threads:[~2023-12-18 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 11:58 Lukas Bulwahn
2023-12-18 13:17 ` Johannes Berg [this message]
2023-12-18 14:59 ` Kalle Valo
2023-12-18 15:03 ` Lukas Bulwahn
2023-12-18 16:16 ` Michael Büsch
2023-12-18 14:59 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26207725d5025318b831dd5a5feca67248aaa221.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=aspriel@gmail.com \
--cc=b43-dev@lists.infradead.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=m@bues.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®