From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbdLENuw (ORCPT ); Tue, 5 Dec 2017 08:50:52 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:32140 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbdLENus (ORCPT ); Tue, 5 Dec 2017 08:50:48 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171205135046epoutp03e690e98c90822fcd512137887e2463ba~9ajnXrD8Z1287212872epoutp03E X-AuditID: b6c32a39-e27ff700000010dd-85-5a26a436b703 From: Bartlomiej Zolnierkiewicz To: Finn Thain Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev Date: Tue, 05 Dec 2017 14:50:55 +0100 Message-id: <2621660.olL7LkYlpq@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <60d598946ac219440cbb1fabed05964e806ebc5f.1512454057.git.fthain@telegraphics.com.au> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsWy7bCmga7ZErUogweTWCwm9i5lsXh2ay+T xYm+D6wWl3fNYbPY/f4+o8WxBWIObB6HDncwejw7+JDV4/MmuQDmKC6blNSczLLUIn27BK6M Cfufshb85qyYcXILawPja/YuRk4OCQETiZ0NV5hAbCGBHYwSWzeGQtjfGSXamwW6GDnAajoP OXcxcgGFdzNK3Go7ywLhfGWUeDixmxWkgU3ASmJi+ypGEFtEQFti4psdbCBFzAILGCXmH97H ApIQFrCRmPdoHhvIVBYBVYkl+5xBwrwCmhK3t18DO0hUwEtiy752sIM4BZIl3qyZxQJRIyjx Y/I9MJtZQF5i3/6prBC2jsTZY+sYQXZJCKxgkzjb8x/qMxeJnu0TGCFsYYlXx7ewQ3wjLXHp qC1EeDqjxPbfEhC9mxklVu2eANVrLXH4+EWoBXwS7772sEL08kp0tAlBlHhInL4HM95R4sHd w8yQQHnBKPH3xFfWCYyys5DcPQvJ3bOQ3L2AkXkVo1hqQXFuemqxYYGpXnFibnFpXrpecn7u JkZwAtCy3MF47JzPIUYBDkYlHt6AGWpRQqyJZcWVuYcYJTiYlUR4mfuBQrwpiZVVqUX58UWl OanFhxilOViUxHlF11+LEBJITyxJzU5NLUgtgskycXBKNTCqf/MqjWi88/mtuULIpjV+qxyU buy/duqS3o82u/bq0MYM7Rz15bwFfRUma7tbjTveBx/bXuBm/3Ly642zj0sfmOG+ZdWXeI4d SpYzLn6TiZx4Se6wwM6t2vIsGqtq5YM8ezx5Z5o3+Fpx6Ytzqavrs+2p+blx86sUh48abn9F 5rLosvmefaDEUpyRaKjFXFScCAAsjxI5/AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t9jAV3TJWpRBrf/a1pM7F3KYvHs1l4m ixN9H1gtLu+aw2ax+/19RotjC8Qc2DwOHe5g9Hh28CGrx+dNcgHMUVw2Kak5mWWpRfp2CVwZ E/Y/ZS34zVkx4+QW1gbG1+xdjBwcEgImEp2HnLsYuTiEBHYySnTdu8MG4XxllNi7cBZQEScH m4CVxMT2VYwgtoiAtsTENzvAipgFFjBKTG89CVYkLGAjMe/RPDaQqSwCqhJL9jmDhHkFNCVu b78GViIq4CWxZV87E4jNKZAssWfOM2aIZS8YJbb2nWSGaBCU+DH5HguIzSwgL7Fv/1RWCFtL Yv3O40wTGPlnISmbhaRsFpKyBYzMqxglUwuKc9Nzi40KDPNSy/WKE3OLS/PS9ZLzczcxAsN2 22Gtvh2M95fEH2IU4GBU4uENmKEWJcSaWFZcmXuIUYKDWUmEl7kfKMSbklhZlVqUH19UmpNa fIhRmoNFSZz3dt6xSCGB9MSS1OzU1ILUIpgsEwenVAPjupXV5y9vNtVv2LiFTbmsfYfRy2mx fyd5SvOLVM81s7GY7yC4ebavyX+WnrJXay0/9V5313/gdOz4zvo9Qc5lL3XaW8+7OXXEMjXu 8K9eFfNpgs9vlYnXN99h2aXIoehYe+zgfSUNsbISqUOqKxknhZhuE86+NM1zz8Pf/nIK0wvF o8Xzbl5RYinOSDTUYi4qTgQAsSmcVVcCAAA= X-CMS-MailID: 20171205135045epcas1p2c546da4a5ac9f4766fd52b55f14959d2 X-Msg-Generator: CA CMS-TYPE: 101P X-CMS-RootMailID: 20171205062004epcas5p2f8586fbcbbe377a56e8403c7566e8c3c X-RootMTR: 20171205062004epcas5p2f8586fbcbbe377a56e8403c7566e8c3c References: <60d598946ac219440cbb1fabed05964e806ebc5f.1512454057.git.fthain@telegraphics.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote: > It is misleading to call a functional resource a "device". In adopting > the Linux Driver Model, the struct device will be embedded in struct > nubus_board. That will compound the terminlogy problem because drivers > will bind with boards, not with functional resources. Avoid this by > renaming struct nubus_dev as struct nubus_rsrc. "Functional resource" > is the vendor's terminology so this helps avoid confusion. > > Cc: Bartlomiej Zolnierkiewicz > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Acked-by: Bartlomiej Zolnierkiewicz for fbdev part > --- > drivers/net/ethernet/8390/mac8390.c | 26 ++++---- > drivers/net/ethernet/natsemi/macsonic.c | 22 +++---- > drivers/nubus/nubus.c | 105 ++++++++++++++++---------------- > drivers/nubus/proc.c | 15 ++--- > drivers/video/fbdev/macfb.c | 2 +- > include/linux/nubus.h | 30 +++++---- > 6 files changed, 98 insertions(+), 102 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics