From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A552FB997 for ; Mon, 24 Nov 2025 11:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763982396; cv=none; b=ewepowdPU/IJ5WiaMcA1UUGbNqGwvaexji+3LVdMgAWpED7eQD63pGCQv05RreF3Yl7P4UChQVDB/o01kMLa+bwTyEoC9eV4jYziUWDbgtsNAmYB0jtLCv5c5tW6hNglMw4SvHVGmtaRE8CmhyM4ce1eP//iPL0Xu2Gj5hxigW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763982396; c=relaxed/simple; bh=CJ8dUbSlQ7jCsg6xWPRrcivBhiDaMlMgVaDwsedR+2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OqV6XjdfTz1vuvHmulH4X904u+FMd8qv0KFo1iZ1MEI6+S+huHxHI3wpo94fgdBxHeCv45fCnwkxCxDX0gVcyOCziWiHSlfItSK0keOQHOtmoJ90+8F53bNWvrJ2O/NIDc4ccud1ud58cPmjfDYdkSsNLFaBPYNnzDlQmmMWBAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GX52aH3a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N0Ktl6QM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GX52aH3a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N0Ktl6QM" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AO7THXU3112197 for ; Mon, 24 Nov 2025 11:06:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= umhaVYhqzRJNctwN1ps//3SxnGdqNok23XI1ZVz0zLo=; b=GX52aH3aeaxo5EhJ fGeKBxbfcQ3XwiN7haa7WCGydj3zRofwqmI9qpzO5yKK2gFlv66kYHqsmbRUIQtM mWZhNAQ6jGHRopXALxVAFhrP9t4gy2MqS1t2yknUV5oalmG7GkpvPEvoG2PpDHWQ qnGPq8ndq9e+FLI5TwJ5TUWg37p84sL3t+w0IopEk738QmY2cQli0nVVSdqzi/0K yyVSbWJB+kqp5jlq39hXBoDQqWhUA3NBVIz1g2XqVVQf0JtBZfx/g7z1r5Yh5vtX HUd12do/igez8rLdLP6D/BnIwN95Rqs7KDFzxxKp3OcScxDH7nue44v2A9klN3Fd MR/ENw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amk10gn9f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 11:06:33 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b2ea2b51cfso119762985a.0 for ; Mon, 24 Nov 2025 03:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763982392; x=1764587192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=umhaVYhqzRJNctwN1ps//3SxnGdqNok23XI1ZVz0zLo=; b=N0Ktl6QMDZ3VdwxHlh6ikNPD9UGMyUr4hHb8jZpQER66MXK6RtVeSOuqNPWtXLzBCE JG6LFFVmhXzZ/o91fAxKRyNaU3OUxVee6zQ0Q30ABDj+ss5c6TLcbaXONiP/WxH++dOr DXgSHlW1OZZaMMUtkeWz2a7/JdAUGwNk8CrFjYKu/acNrdf8s1DoLg9RD7XUehz7gsmq RzwWyy+YLvJqvfaihikKOSXjXEH3gwTSWsqTXj4ivsLOg/vKBZHVvgCdSwI1I9+TWESI g+LtPf0/lxRBbCf4qf5C9MrBvX6PRTauPMapuGBlUUbIiLVcZvggn+O4rEgPVulXL/pW nztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763982392; x=1764587192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=umhaVYhqzRJNctwN1ps//3SxnGdqNok23XI1ZVz0zLo=; b=dwDjSSIVxFlUSFj0V6ZTS8ghOcOE01q/CbFG8PIMmHUPJ+z8qwByTAmEApn4chGbQt SEnpzkDoaF3yC9WbBdswX5hWaplTYUPwpl1Ff6Qxmhl2ayH9KLoZVU0hsZ4+CcqAKCzW Dys7ZygeM90KhKAqL6way0A2KZ4ztAMY+k9ebWk8M50PG4VyTQLGlKnqmHzPHV7HvIgb kQ8T3qjl/5ZGJt+wD91s61Bw3I8dsE+YFwiepU6Xc7SxMaOCnIeK8zAcPZJ/FdvUrzE3 6+riCfIsr0khZ0MSKohLfY5GPVBCp+aHqGkRZnENebxA/Um0RlMveJfpN2fipEhKGgDW mxUw== X-Forwarded-Encrypted: i=1; AJvYcCX6GpsR6L6+fdSp/Fp8d5hJixZ1BJ3cNXOx5I0SPDDNCHxYcvCb9PNh5E7LgVJ/8ubj8lwa9yQ7h1BcQmg=@vger.kernel.org X-Gm-Message-State: AOJu0YyAXskW8MF5puUxCbiHeFMjeqwdC4oIL4zExeVBfm11FKT8HdO9 y3mucWKadPexbm63jNu+k8BOohNcdC1/OGAZe8Y+zbaLDlR7nwjZEzzTm9DNG/5E5F9ajrsF12s 2IL+1I64ig2L6F8kfEemgoz2/3xpZeTqlGzEMkNvsTPEqzA9JtTX+cVQ0h2THEqP3p0g= X-Gm-Gg: ASbGncubXb7lOtmCYeKCIV0fXyYq2DHrFYHbFqIljwoCJ8zIUaR6HvqI/arlXztzRiw ZYaaCxNxMDgKZoAhHnJgPPjKmz7lJCNVyVAMTvbRlsQxSI5/qe//2d3QOcawE2Iv2MZdLrWVN/+ 3XIzRyYXwz7Ykg4A4owxJRjJXCUu9hdQ3A1+dS/McWMM2qasBp12R+jSSqcaHFevxvs4ksjcfC2 RenDNY36FKiLBvmzCJtIfKfdyZGyAq3bKgxSyjxbb3Nqz+Wh8MJ/1zhMxubWdXSfunaOMpB5azr sGn+luBURIOPQVt0bBhdRjtKhJn4W6hjSTh87nAXtpSRqQYT9xfIi5cW4opd474CKm5pXewbaPa jv3tfaRRwGLlah9BNQ4uXwEuKX7DOTrV/1vQ/SKvhzE+eaIRVe7Ma0Z8g008Q9PWbXHI= X-Received: by 2002:a05:622a:10e:b0:4ee:1f0c:c19d with SMTP id d75a77b69052e-4ee5b45a447mr106741251cf.0.1763982391956; Mon, 24 Nov 2025 03:06:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGqsaQwNFnOAMYmTTZx3DN112lIwtKTFS+z3griOhtKAWBaF+LSoOoX9RPfblnZNkwsXl78LQ== X-Received: by 2002:a05:622a:10e:b0:4ee:1f0c:c19d with SMTP id d75a77b69052e-4ee5b45a447mr106740881cf.0.1763982391577; Mon, 24 Nov 2025 03:06:31 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-645363ac97esm11984833a12.1.2025.11.24.03.06.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 03:06:30 -0800 (PST) Message-ID: <2622656e-9abd-4407-b1fa-228da9959d60@oss.qualcomm.com> Date: Mon, 24 Nov 2025 12:06:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: venus: vdec: restrict EOS addr quirk to IRIS2 only To: Dikshita Agarwal , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , Viswanath Boma , Stanimir Varbanov Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Renjiang Han , Mecid Urganci References: <20251124-venus-vp9-fix-v1-1-2ff36d9f2374@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251124-venus-vp9-fix-v1-1-2ff36d9f2374@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -5ungIBR0PwIgDT0gjvT_dC2gwvvzRr2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDA5OCBTYWx0ZWRfX8w72LaONvUKL mbvfQ8z645HLvcdsEIjE4PeI6mkgvC8o+cfXZH9FA4DkJ3V02T+ZRIUeMo93NBNPUY4fuxk5R15 9w19Z1cPrVYESxAhUInqTUM7N47UBuqEX+3aFyfccStbahEN8CJg4ttu91gzC4aD60ro1znUsWA NslsEsLBgJoamAVVWJLITuqQs+fGxWUV2dEbg/sxl+8VVKT4kuph6yVRAs71FW7gUDACE/bh+En OTdacJTfdF+MxXP600t+bhpFOiUa9I6nIIRyWPGDSCIMiL9SKI8tgUEaUdZmKu3ifZ9aCds2bJ3 bqLDswscOF3LqPNHSkqKNi2Oszgt0qCzcKeDJ71h6+X6hjRTdMtgM0mHJEgwfi12cSF3jF7y8mu Mjpahm870Q4bP1YmJaDVTszBDAEYsg== X-Proofpoint-ORIG-GUID: -5ungIBR0PwIgDT0gjvT_dC2gwvvzRr2 X-Authority-Analysis: v=2.4 cv=SP9PlevH c=1 sm=1 tr=0 ts=69243c39 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=wfby7z1SNJwdpBdL-ZgA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_04,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240098 On 11/24/25 11:58 AM, Dikshita Agarwal wrote: > On SM8250 (IRIS2) with firmware older than 1.0.087, the firmware could > not handle a dummy device address for EOS buffers, so a NULL device > address is sent instead. The existing check used IS_V6() alongside a > firmware version gate: > > if (IS_V6(core) && is_fw_rev_or_older(core, 1, 0, 87)) > fdata.device_addr = 0; > else > fdata.device_addr = 0xdeadb000; > > However, SC7280 which is also V6, uses a firmware string of the form > "1.0.", which the version parser translates to 1.0.0. This > unintentionally satisfies the `is_fw_rev_or_older(..., 1, 0, 87)` > condition on SC7280. Combined with IS_V6() matching there as well, the > quirk is incorrectly applied to SC7280, causing VP9 decode failures. > > Constrain the check to IRIS2 (SM8250) only, which is the only platform > that needed this quirk, by replacing IS_V6() with IS_IRIS2(). This > restores correct behavior on SC7280 (no forced NULL EOS buffer address). This really needs an inline comment, since you provided a long backstory explaining how fragile this check is > Fixes: 47f867cb1b63 ("media: venus: fix EOS handling in decoder stop command") > Cc: stable@vger.kernel.org > Reported-by: Mecid This is certainly not a correct email to use... it will at best bounce or get ignored and at worst cause some unintended interactions with gh if you have an account registered with the email you're sending from I opened that person's GH profile and grabbed the git identify of a recent commit made attributed to this account: Mecid Urganci (+CC Mecid, -CC github, fwiw) Konrad