From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F700ECAAD4 for ; Wed, 31 Aug 2022 13:06:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbiHaNGQ (ORCPT ); Wed, 31 Aug 2022 09:06:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbiHaNGO (ORCPT ); Wed, 31 Aug 2022 09:06:14 -0400 X-Greylist: delayed 465 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 31 Aug 2022 06:06:12 PDT Received: from smtp126.ord1c.emailsrvr.com (smtp126.ord1c.emailsrvr.com [108.166.43.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6328ABB92A for ; Wed, 31 Aug 2022 06:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1661950705; bh=0KcZlJccqHicNmaRgVPiDmAuxUe7nb/278cWgizWaGQ=; h=Date:Subject:To:From:From; b=OPrZeTdJNfQhcaza09qAyFjQh4ZYjZbsxcBm31jlrUfOzaWJ/aBRqvGge7B6VUZu0 54ONJJteoNeqzpBUmx067fY427Teb7qDImUd+SeeosZ/T08aFNjQC4og2zykj0hnaz SvriQrKkF7NEpMvRTNV1TOWbON+TAufBJKhAIHX4= X-Auth-ID: abbotti@mev.co.uk Received: by smtp24.relay.ord1c.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 2ECC46016D; Wed, 31 Aug 2022 08:58:25 -0400 (EDT) Message-ID: <26274f3d-75fd-3653-e1f3-11ce52f402ee@mev.co.uk> Date: Wed, 31 Aug 2022 13:58:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit Content-Language: en-GB To: Xuezhi Zhang , hsweeten@visionengravers.com, gregkh@linuxfoundation.org, zhangxuezhi1@coolpad.com Cc: linux-kernel@vger.kernel.org References: <20220831125520.239055-1-zhangxuezhi3@gmail.com> From: Ian Abbott Organization: MEV Ltd. In-Reply-To: <20220831125520.239055-1-zhangxuezhi3@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: d1fc4daa-60b2-4b34-b65e-daa36668d751-1-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/08/2022 13:55, Xuezhi Zhang wrote: > From: zhangxuezhi1 > > Fix up all sysfs show entries to use sysfs_emit > > Signed-off-by: Xuezhi Zhang > --- > v2: use a proper name for the Signed-off-by line. > --- > drivers/comedi/comedi_fops.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c > index 55a0cae04b8d..e2114bcf815a 100644 > --- a/drivers/comedi/comedi_fops.c > +++ b/drivers/comedi/comedi_fops.c > @@ -396,7 +396,7 @@ static ssize_t max_read_buffer_kb_show(struct device *csdev, > mutex_unlock(&dev->mutex); > > comedi_dev_put(dev); > - return snprintf(buf, PAGE_SIZE, "%u\n", size); > + return sysfs_emit(buf, "%u\n", size); > } > > static ssize_t max_read_buffer_kb_store(struct device *csdev, > @@ -452,7 +452,7 @@ static ssize_t read_buffer_kb_show(struct device *csdev, > mutex_unlock(&dev->mutex); > > comedi_dev_put(dev); > - return snprintf(buf, PAGE_SIZE, "%u\n", size); > + return sysfs_emit(buf, "%u\n", size); > } > > static ssize_t read_buffer_kb_store(struct device *csdev, > @@ -509,7 +509,7 @@ static ssize_t max_write_buffer_kb_show(struct device *csdev, > mutex_unlock(&dev->mutex); > > comedi_dev_put(dev); > - return snprintf(buf, PAGE_SIZE, "%u\n", size); > + return sysfs_emit(buf, "%u\n", size); > } > > static ssize_t max_write_buffer_kb_store(struct device *csdev, > @@ -565,7 +565,7 @@ static ssize_t write_buffer_kb_show(struct device *csdev, > mutex_unlock(&dev->mutex); > > comedi_dev_put(dev); > - return snprintf(buf, PAGE_SIZE, "%u\n", size); > + return sysfs_emit(buf, "%u\n", size); > } > > static ssize_t write_buffer_kb_store(struct device *csdev, Looks good, thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-