mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Quentin Schulz <quentin.schulz@bootlin.com>
Cc: linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init
Date: Wed, 10 Oct 2018 10:27:20 +0200	[thread overview]
Message-ID: <26277f5e-935c-98fa-8d39-83e66c78ab30@embeddedor.com> (raw)
In-Reply-To: <20181010064902.qnrkoi3wdf6hlyac@qschulz>

Hey Quentin,

On 10/10/18 8:49 AM, Quentin Schulz wrote:

>>  
>>  out:
>>  	phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
>> -
>> +release_fw:
>>  	release_firmware(fw);
> 
> You can reuse the out goto label instead, I would like all functions in
> the driver to exit with the PHY set to access the standard page.
> 

Oh okay. I've got it.

I'll send v2 shortly.

Thanks for the feedback.
--
Gustavo

      reply	other threads:[~2018-10-10  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 19:38 [PATCH net-next 0/2] fix signedness bug and memory leak in mscc driver Gustavo A. R. Silva
2018-10-09 19:38 ` [PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get Gustavo A. R. Silva
2018-10-10  6:56   ` Quentin Schulz
2018-10-09 19:39 ` [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init Gustavo A. R. Silva
2018-10-10  6:49   ` Quentin Schulz
2018-10-10  8:27     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26277f5e-935c-98fa-8d39-83e66c78ab30@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quentin.schulz@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome