From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
Yannick Fertre <yannick.fertre@foss.st.com>,
Christophe Roullier <christophe.roullier@foss.st.com>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: linux-watchdog@vger.kernel.org,
"Clément Le Goffic" <clement.legoffic@foss.st.com>,
"Amelie Delaunay" <amelie.delaunay@foss.st.com>,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v4 06/15] ARM: stm32: enable arm smc watchdog on stm32mp1xx
Date: Mon, 16 Nov 2026 17:45:38 +0100 [thread overview]
Message-ID: <2628f6e623996cda73a8cad46d451a629e749462.camel@foss.st.com> (raw)
In-Reply-To: <32157be8-28c1-403d-8485-96c1fe4543ef@roeck-us.net>
On Mon, 2026-11-16 at 06:33 -0800, Guenter Roeck wrote:
> On 11/16/26 05:24, Antonio Borneo wrote:
> > The watchdog IWDG1 is secure by default on STM32MP1xx SoCs.
> > On boards that keep it secure, Linux must use the arm,smc-wdt
> > driver to ping it.
> >
> > Enable the driver for mach-stm32 when ARCH_MULTI_V7 is enabled.
> >
>
> As mentioned before, that doesn't just enable it for STM32MP1xx SoCs,
> it force-enables it for all boards running ARCH_MULTI_V7. It also
> goes well beyond the current scope of "if ARCH_MULTI_V7" configurations.
> I would suggest NACK for that reason, but that isn't my call to make.
>
> Guenter
Hi Guenter,
sorry if I take more of your time on this, but I haven't got your comments on
my reply to this patch as v3 04/13.
On platforms STM32MP1xx the trusted firmware starts the watchdog.
Since on such platforms the defconfig is multi_v7_defconfig, the upstream kernel
configured with multi_v7_defconfig would need ARM_SMC_WATCHDOG to prevent a reset
during kernel boot.
Clearly, my wish is to have an upstream kernel booting properly with defconfig.
arch/arm/mach-stm32/Kconfig handles two series of ARCH_STM32:
- the deprecated ARMv7M platforms that use stm32_defconfig;
- the ARMv7A platforms that use multi_v7_defconfig.
In this patch the condition 'if ARCH_MULTI_V7' is to enable the watchdog only
on ARMv7A, not on ARMv7M.
Clearly any driver enabled for ARCH_STM32 will automatically be enabled for
the other SoC that rely on the same defconfig.
Also reworking this patch by moving the change in drivers/watchdog/Kconfig as
config ARM_SMC_WATCHDOG
+ default y if (ARCH_STM32 && ARCH_MULTI_V7)
would still result in the arm SMC watchdog enabled for all the SoC that use
multi_v7_defconfig.
What would be your suggestion to progress on this topic?
Thanks,
Antonio
>
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> > ---
> > arch/arm/mach-stm32/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
> > index 4ac3384e397aa..de09b2afa0f2e 100644
> > --- a/arch/arm/mach-stm32/Kconfig
> > +++ b/arch/arm/mach-stm32/Kconfig
> > @@ -13,6 +13,8 @@ menuconfig ARCH_STM32
> > select RESET_CONTROLLER
> > select STM32_EXTI if ARM_SINGLE_ARMV7M
> > select STM32_FIREWALL
> > + select WATCHDOG if ARCH_MULTI_V7
> > + select ARM_SMC_WATCHDOG if ARCH_MULTI_V7
> > help
> > Support for STMicroelectronics STM32MP1 processors using Cortex-A7
> > cores. Note that support for the earlier Cortex-M based variants
>
next prev parent reply other threads:[~2026-11-16 16:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 13:24 [PATCH v4 00/15] Update watchdogs support on STM32MP platforms Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 01/15] watchdog: stm32_iwdg: set driver data before requesting interrupt Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 02/15] watchdog: stm32_iwdg: serialize accesses to EWCR register Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 03/15] watchdog: stm32_iwdg: get hardware version during probe Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 04/15] watchdog: stm32_iwdg: detect whether the watchdog is running Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 05/15] watchdog: stm32_iwdg: add pretimeout support for iwdg v4.0 Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 06/15] ARM: stm32: enable arm smc watchdog on stm32mp1xx Antonio Borneo
2026-11-16 14:33 ` Guenter Roeck
2026-11-16 16:45 ` Antonio Borneo [this message]
2026-11-16 18:00 ` Guenter Roeck
2026-11-16 18:26 ` Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 07/15] dt-bindings: watchdog: st,stm32-iwdg: add access-controllers property Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 08/15] ARM: dts: stm32: add iwdg1 node on stm32mp151 SoC Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 09/15] ARM: dts: stm32: enable iwdg1 on stm32mp15x ST boards Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 10/15] ARM: dts: stm32: move arm smc watchdog to stm32mp151 SoC Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 11/15] ARM: dts: stm32: enable arm smc watchdog on stm32mp15x scmi boards Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 12/15] ARM: dts: stm32: add watchdog0 alias on ST stm32mp1xx boards Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 13/15] arm64: dts: st: add iwdg1 and iwdg2 support to stm32mp231 Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 14/15] arm64: dts: st: add iwdg1 and iwdg2 support to stm32mp251 Antonio Borneo
2026-11-16 13:24 ` [PATCH v4 15/15] arm64: dts: st: enable iwdg2 on stm32mp2xx ST boards Antonio Borneo
2026-11-16 14:37 ` [PATCH v4 00/15] Update watchdogs support on STM32MP platforms Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2628f6e623996cda73a8cad46d451a629e749462.camel@foss.st.com \
--to=antonio.borneo@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=christophe.roullier@foss.st.com \
--cc=clement.legoffic@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®