From: David Howells <dhowells@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
Baptiste Lepers <baptiste.lepers@gmail.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Call state should be read with READ_ONCE() under some circumstances
Date: Wed, 13 Jan 2021 08:23:54 +0000 [thread overview]
Message-ID: <2630109.1610526234@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210112182533.13b1c787@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 12 Jan 2021 15:59:15 +0000 David Howells wrote:
> > From: Baptiste Lepers <baptiste.lepers@gmail.com>
> >
> > The call state may be changed at any time by the data-ready routine in
> > response to received packets, so if the call state is to be read and acted
> > upon several times in a function, READ_ONCE() must be used unless the call
> > state lock is held.
> >
> > As it happens, we used READ_ONCE() to read the state a few lines above the
> > unmarked read in rxrpc_input_data(), so use that value rather than
> > re-reading it.
> >
> > Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
> > Signed-off-by: David Howells <dhowells@redhat.com>
>
> Fixes: a158bdd3247b ("rxrpc: Fix call timeouts")
>
> maybe?
Ah, yes. I missed there wasn't a Fixes line. Can you add that one in, or do
I need to resubmit the patch?
David
next prev parent reply other threads:[~2021-01-13 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 15:59 David Howells
2021-01-13 2:25 ` Jakub Kicinski
2021-01-13 8:23 ` David Howells [this message]
2021-01-13 18:41 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2017-03-04 0:01 David Howells
2017-03-07 21:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2630109.1610526234@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=baptiste.lepers@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®