From: Benjamin Berg <benjamin@sipsolutions.net>
To: Chris Chiu <chiu@endlessm.com>, Daniel Drake <drake@endlessm.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Upstreaming Team <linux@endlessm.com>,
Jian-Hong Pan <jian-hong@endlessm.com>
Subject: Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support
Date: Mon, 04 Jun 2018 11:27:43 +0200 [thread overview]
Message-ID: <2634178c3b1fb2c1174eae0d67419e285e2f7c26.camel@sipsolutions.net> (raw)
In-Reply-To: <CAB4CAwfEyS0j+q_hM8u-XHU_rEFq3604gjsSw4d_4mhaiz=G-A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
Hi,
On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote:
> I've made my change to set the brightness level directly in the
> driver, but the
> OSD doesn't show correctly correspond to the level value. The brightness shows
> OK in /sys/class/led/xxxx/brighness but the OSD always shows level 0. I thought
> GNOME should read the brightness from /sys before showing OSD?
Sorry for the late response.
There is a special mechanism to report that the HW changed the
brightness. This works using the "brightness_hw_changed" sysfs
attribute. So you will need to set the LED_BRIGHT_HW_CHANGED flag on
the LED and then call led_classdev_notify_brightness_hw_changed to make
it work.
Userspace should correctly show the OSD when this is done.
Benjamin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-04 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 3:04 Chris Chiu
2018-05-07 14:10 ` Andy Shevchenko
2018-05-07 14:46 ` Daniel Drake
2018-05-15 0:25 ` Daniel Drake
2018-05-15 7:52 ` Andy Shevchenko
2018-05-15 13:41 ` Benjamin Berg
2018-05-22 9:18 ` Andy Shevchenko
2018-05-22 10:11 ` Chris Chiu
2018-05-22 13:48 ` Daniel Drake
2018-05-24 8:33 ` Chris Chiu
2018-06-04 9:27 ` Benjamin Berg [this message]
2018-06-05 1:59 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2634178c3b1fb2c1174eae0d67419e285e2f7c26.camel@sipsolutions.net \
--to=benjamin@sipsolutions.net \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=chiu@endlessm.com \
--cc=corentin.chary@gmail.com \
--cc=drake@endlessm.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jian-hong@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®