From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.com>,
Matthew Wilcox <willy@infradead.org>,
Mike Rapoport <rppt@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] block: partitions: replace __get_free_page() with kmalloc()
Date: Wed, 27 May 2026 15:16:18 +0200 [thread overview]
Message-ID: <26361fb4-54bb-4db6-9394-640ab7115b4f@suse.de> (raw)
In-Reply-To: <ahbti6M8zRWR1oGa@infradead.org>
On 5/27/26 15:11, Christoph Hellwig wrote:
> On Wed, May 27, 2026 at 12:04:29PM +0200, Hannes Reinecke wrote:
>> Precisely my reasoning. In most cases, __get_free_page() is just a
>> lazy way of saying "I need some memory and the allocation should not fail".
>
> Huh? __get_free_page and kmalloc can and should fail.
>
Even better, one argument less why it should not be converted :-)
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
prev parent reply other threads:[~2026-05-27 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 8:15 Mike Rapoport (Microsoft)
2026-05-25 6:08 ` Christoph Hellwig
2026-05-25 6:52 ` Mike Rapoport
2026-05-25 7:16 ` Christoph Hellwig
2026-05-25 9:35 ` Mike Rapoport
2026-05-26 6:27 ` Christoph Hellwig
2026-05-26 12:07 ` Vlastimil Babka
2026-05-26 14:37 ` Matthew Wilcox
2026-05-26 20:57 ` Vlastimil Babka
2026-05-27 10:04 ` Hannes Reinecke
2026-05-27 13:11 ` Christoph Hellwig
2026-05-27 13:16 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26361fb4-54bb-4db6-9394-640ab7115b4f@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=vbabka@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®