From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262AbbKBVpl (ORCPT ); Mon, 2 Nov 2015 16:45:41 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:51560 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753489AbbKBVph (ORCPT ); Mon, 2 Nov 2015 16:45:37 -0500 From: Arnd Bergmann To: Daniel Lezcano Cc: linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, Heiko Stuebner , linux-kernel@vger.kernel.org, "open list:ARM/Rockchip SoC..." , john.stultz@linaro.org, Caesar Wang Subject: Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible Date: Mon, 02 Nov 2015 22:44:56 +0100 Message-ID: <26365416.grsdrqtSNb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56379016.1080601@linaro.org> References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <5093304.EN6Bc2EjLr@wuerfel> <56379016.1080601@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TuH6lBn4YyKvvS7tS0/zfuxVvC1Te9fHXMfuJ5Sv4wSC9B5LfxE 979yPidxrbJ6SZURM1apvL5r1gaNsUZhJ9rjpGMCZUwxHlSKR+OFMpU6i2eN5tBr0eze8yn QWQhcpY94WZ+oiKwCNMX7/WdQ/blY5BEBIZOCNOt06FJ78ES0fOWqlnDAOvrisMwhTBTOqT yjDGrBkEtDZT0lxEAwp1w== X-UI-Out-Filterresults: notjunk:1;V01:K0:qXJ9J8dgFa4=:K77g5BxK7Q6WwJhIp4CWtj aK0R4hLGLgDG9c9Xl097XeLJotHgri5L8sni+PxYj7fugcmaiP/oirT/sE5cFBUA2JF+knqnn XGuEOTGlU9vX4JGJNf2WHMTS+hbQptoPgz0TLHgu172aEwQwKrqXpIQzTe0wJbzaqbjupJQYi piQIvWMy5uDQXdJPeW1vSu81Z4jJit4N2TMFfZV5qUkE9yHJPIZ/szEvp9ktyYVx9AtVJjZFY OI5WF20K5Qmar38dUbZoF0mGZZD8sON+fFtgHdnBm1GRXn5UNF2JYDsovSUCWh+UqjBDJrjzb lecFFcF3VWSjTMJ9U4+EoyXGJQqcanHiaeyV32fmlG5aNnTR3iOnKf10vcQ4CRRBOzmf0p4MZ 6c7BTVO2grsn83jTN0MfUylDbdAjchYww83j+O1lGLw/xNuq5oLKeyg20iEkZIrbcXdacBM0Y 1ndHAS/GN6O8LB5Nj6vb/oek13IuNmqNql576P5GozZbtwF2YPZERbIjyReaVn9yeJJGAufmj h7QVCzCfkxAXczLET08aW2pM6sTSeHlrqIZZrqJpTkVYOS97212RR3Bvdp8S2NvQLAUaNbvLX a4Uvxj6l63I/qR0HMiGEHhMRYjlrK65kNAnHgOfSkHdPprzLvshYi/SaaPyxQtIi69tsdz4oi e18m2zzIOoK81fVW2C854JqDLSkmv+/K+8KrtUJvHyNq700LJYtkN9RrA389EK1lXWQd6sd0e KmXTzuefSR5d90xm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 November 2015 17:32:22 Daniel Lezcano wrote: > On 11/02/2015 04:33 PM, Arnd Bergmann wrote: > > On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote: > >> static inline void rk_timer_disable(struct clock_event_device *ce) > >> { > >> writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG); > >> - dsb(); > >> + dsb(sy); > >> } > >> > >> static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags) > >> { > >> writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags, > >> rk_base(ce) + TIMER_CONTROL_REG); > >> - dsb(); > >> + dsb(sy); > >> } > >> > >> > > > > This will fail the compile test, because dsb() is not available on non-ARM > > architectures. Would it be enough to just use the normal writel() accessor > > here? > > That's a good question and I believe we can remove it but I have to > setup a rockchip board before doing the changes in order to test. > > I the meantime added the COMPILE_TEST option but restricted it to ARM > and ARM64. > Ok. I saw that addition after commenting here, it looks correct this way, I was just slightly confused by seeing patch 2 first and thought it was for the same driver. In general, it would of course be best to allow all drivers to be built on x86, but your series is already a huge improvement as it is. Arnd