mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: dancer@debian.org, mst@redhat.com
Cc: qemu-devel@nongnu.org, adelva@google.com, uekawa@chromium.org,
	linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
	kvm@vger.kernel.org
Subject: Re: [PATCH] Fix comment for virtio-9p
Date: Tue, 27 May 2025 09:11:36 +0300	[thread overview]
Message-ID: <2636618a-5000-449a-bc2d-f7bf253bf26d@tls.msk.ru> (raw)
In-Reply-To: <20250527041123.840063-1-dancer@debian.org>

27.05.2025 07:11, dancer@debian.org wrote:
> From: Junichi Uekawa <uekawa@chromium.org>
> 
> virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> like an artifact of old copy-and-paste error.

> -#define VIRTIO_ID_9P			9 /* 9p virtio console */
> +#define VIRTIO_ID_9P			9 /* virtio 9p */

While the old one was obviously wrong, I don't think the new
wording makes much sense, since it merely repeats the name of
the constant :)

How about "virtio 9p file sharing protocol" instead ? :)

/mjt

  reply	other threads:[~2025-05-27  6:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  4:11 dancer
2025-05-27  6:11 ` Michael Tokarev [this message]
2025-05-27  6:23   ` Junichi Uekawa
2025-05-27  6:22 ` dancer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2636618a-5000-449a-bc2d-f7bf253bf26d@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=adelva@google.com \
    --cc=dancer@debian.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=uekawa@chromium.org \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®