From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757392AbcBXQ1H (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Feb 2016 11:27:07 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:51712 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752099AbcBXQ1F (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Feb 2016 11:27:05 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>, Alexander Shiyan <shc_work@mail.ru>,
        Pankaj Dubey <pankaj.dubey@samsung.com>,
        Pawel Moll <pawel.moll@arm.com>, Wolfram Sang <wsa@the-dreams.de>,
        Peter Seiderer <ps.report@gmx.net>,
        Tushar Behera <tushar.behera@linaro.org>, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v2] mfd: syscon: allow to register syscon with a device
Date: Wed, 24 Feb 2016 17:26:46 +0100
Message-ID: <2637460.3ZCmmf9MXm@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1456326148.3396.43.camel@pengutronix.de>
References: <1456312741-7658-1-git-send-email-p.zabel@pengutronix.de> <2970085.kbMT7OBsMB@wuerfel> <1456326148.3396.43.camel@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:gY5pNucAsA/tdnotKCp09NkuHR3TYaraRGKnQcMYC8g0tWxd/gt
 nXZw/7hvS275mYaZqBCezt01I3nSkNAOSfv1QZK/z7FogvNl6RjY8MTZ+fECkXbga15+Z5A
 7nhZfMB/TSp4aK0aBkcMPEwImvpnCPaSpM4ofF9TnUmy/8vpxOsklK/4VBSiKHnq64Vc3QR
 N+rllmZ6dfx1XhegP30BA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4Rx6MuWcPGA=:ljAsGqgakXw9HexQALsJ74
 HPE/6AmIM/LXMBX+g069tALnFi5g03H5WB3/MKYF+zjJXTKkG293cgnAp/J8ZOOSeAxug1j/8
 kLpKiVZykp3RG3GfxPwufAi4lroz9g9ecu3583xLjxqvwFqXN+Xc9qdXQFI7D0tLj31UB9Hlg
 SKXqaGFTBqHIdyxd1/iP27GIWnWV43pLnVReoH0luZq5pzV+2xgK1/QBHmBAJWrMqcAc7ZSsd
 F+UmaBAbIZKtoQGOieVOfYJUiel7p6Lgte62PoAxMZ790J95b6byGphfT7MCM3s01MrjLrT++
 RG6IHJ4bMwCSZykb799LsPjGN88JvpOaxxc+932qDfrbRZ7lTs/TWfUG7Ea8G8Zef3qZK81/D
 IeZPFoak5+UXcLmIFGd63c0JvUtL0PjlZ3t0Q7QyzR7B3fs/Qloc4dsxhKkjVIPL1fKvkFFgg
 2oIqqcE4bFVZXh6bSw2EN2GQT2ZtVRtdOkU69FOG1jKOEXpZ2GbO1VV2Zlqisj8dtFrq4du10
 8dpGjznh88Gyw4HgXSg+7fUkryt3dYuaycHqEZ0HHQ/k0o0PdL5tXbS4lrynI1w00SBD7SCO/
 z6RE25yn604AtW+ILLXn+o4nmovVlG7B+OgpMDbpL3zIPQELasvE//iOvGdNfsgmDTvjVLzKM
 ZWZChO9tk33qQg7kKc6BcDfVU+/sWG6Lu7k+cgsiSFU/nPXZS63sipAi590/zx3m8Wc98vUWC
 Zf78fUVeDopQDgCp
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 24 February 2016 16:02:28 Philipp Zabel wrote:
> > > @@ -473,6 +474,12 @@ static const struct of_device_id imx6q_pinctrl_of_match[] = {
> > >  
> > >  static int imx6q_pinctrl_probe(struct platform_device *pdev)
> > >  {
> > > +       struct device_node *syscon_np;
> > > +
> > > +       syscon_np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-iomuxc-gpr");
> > > +       if (syscon_np)
> > > +               syscon_register(&pdev->dev, syscon_np);
> > > +
> > >         return imx_pinctrl_probe(pdev, &imx6q_pinctrl_info);
> > >  }
> > >  
> > > The pinctrl driver is probed at arch_initcall time.
> > 
> > I still don't see it where you are getting with this. Is this just for
> > the debugfs interface or is there something else this does on top of
> > that?
> 
> Sorry, yes, this is about the missing debugfs functionality.

Ok, so maybe there is a different way of doing this: If I understood
it correctly, we now lost the debugfs handling on all syscon nodes?

Should we try to come up with a way to bring it back for all of them
then, rather than having to do it per device?

I can see two possible ways of doing that:

a) change the regmap code to provide a debugfs interface for all
   regmaps, including those without a device
b) change the syscon driver to explicitly register the debugfs
   interface at a later point in boot when the devices become
   available

	Arnd