From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] cpufreq: Always remove sysfs cpuX/cpufreq link on ->remove_dev()
Date: Mon, 23 Nov 2015 23:47:24 +0100 [thread overview]
Message-ID: <2639074.3VUozvte35@vostro.rjw.lan> (raw)
In-Reply-To: <1448116929.3069.1.camel@linux.intel.com>
On Saturday, November 21, 2015 06:42:09 AM Srinivas Pandruvada wrote:
> On Sat, 2015-11-21 at 09:06 +0530, Viresh Kumar wrote:
> > Subsys interface's ->remove_dev() is called when the cpufreq driver
> > is
> > unregistering or the CPU is getting physically removed. We keep
> > removing
> > the cpuX/cpufreq link for all CPUs except the last one, which is a
> > mistake as all CPUs contain a link now.
> >
> > Because of this, one CPU from each policy will still contain a link
> > (to
> > an already removed policyX directory), after the cpufreq driver is
> > unregistered.
> >
> > Fix that by removing the link first and then only see if the policy
> > is
> > required to be freed. That will make sure that no links are left out.
> >
> > Fixes: 96bdda61f58b ("cpufreq: create cpu/cpufreq/policyX
> > directories")
> > Reported-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
>
> Tested-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com
Applied, thanks!
Rafael
prev parent reply other threads:[~2015-11-23 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448074212.3450.4.camel@linux.intel.com>
2015-11-21 3:34 ` [PATCH] " Viresh Kumar
2015-11-21 3:36 ` [PATCH V2] " Viresh Kumar
2015-11-21 14:42 ` Srinivas Pandruvada
2015-11-23 22:47 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2639074.3VUozvte35@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®