From: "John Stoffel" <john@stoffel.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: manas18244@iiitd.ac.in, linux-bcachefs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Anup Sharma <anupnewsmail@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
syzbot+e8eff054face85d7ea41@syzkaller.appspotmail.com
Subject: Re: [PATCH] Revert "bcachefs: Add asserts to bch2_dev_btree_bitmap_marked_sectors()"
Date: Thu, 24 Oct 2024 14:30:34 -0400 [thread overview]
Message-ID: <26394.37450.21740.720541@quad.stoffel.home> (raw)
In-Reply-To: <rd4maufxfunrcpzkoo2jszorzl256fiktw3p5yfpnjpu2ajh4l@5wvkfxwzajax>
>>>>> "Kent" == Kent Overstreet <kent.overstreet@linux.dev> writes:
> On Mon, Oct 21, 2024 at 10:18:57PM +0530, Manas via B4 Relay wrote:
>> From: Manas <manas18244@iiitd.ac.in>
>>
>> This reverts commit 60f2b1bcf519416dbffee219132aa949d0c39d0e.
>>
>> This syzbot bug[1] is triggered due to the BUG_ON assertions added in
>> __bch2_dev_btree_bitmap_mark. During runtime, m->btree_bitmap_shift is
>> 63 '?'. This triggers both the assertions.
> The BUG_ON() doesn't need to be deleted; we just need to fix the
> validation so it doesn't fire (it doesn't particularly matter if it's
> removed or not, ubsan would catch it without the BUG_ON()).
Shouldn't the BUG_ON() be replaced with making the filesystem readonly
instead if you're going to keep it? I'd rather have the filesystem
still be mounted and able to be read, but not writeable, instead of
having my system crash before I can do anything.
John
next prev parent reply other threads:[~2024-10-24 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 16:48 Manas via B4 Relay
2024-10-22 1:43 ` Hongbo Li
2024-10-22 13:59 ` Manas
2024-10-24 11:36 ` Kent Overstreet
2024-10-24 18:30 ` John Stoffel [this message]
2024-10-24 21:36 ` Kent Overstreet
2024-10-25 21:26 ` John Stoffel
2024-10-25 23:02 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26394.37450.21740.720541@quad.stoffel.home \
--to=john@stoffel.org \
--cc=anupnewsmail@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manas18244@iiitd.ac.in \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+e8eff054face85d7ea41@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®