From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B1603806A6 for ; Mon, 3 Aug 2026 16:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773478; cv=none; b=BogMGhR7pJgRv9qAOrkm6io0nRzKSpHOwDxfDNDlcpoPrKVI9N+b867a6wlNoJKVGa8H/BaJfmHktMly+MKSx5jnHfk2QRkRT/DSa43yo+LTQnzYuMVwqBYbLrFbfgAD2QqjSKQMGKegm60+VdvhaDBuab6GfJWDCUSXL/A4d7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785773478; c=relaxed/simple; bh=PWwlgog84rReNxIXHZ44trRlgx66npQPNSF2KxN5bIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gid5nCpFMOsRM+g6HZhlQC7LihLVsC78VQENtXIb13PvbgztnC9vS8Vid/VwGgBLGM1m2Qa5uedJgE0gNz9+KCnax+to0Xo4q6NhnJY0/2iKp/jw8k8YMiELKcKpd7s1xqiJ7ZAwMq6P97GAHD8FCw2gc4KDOzapdO70HXCJnns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XL/NQEOV; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XL/NQEOV" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49558ce01afso18090155e9.1 for ; Mon, 03 Aug 2026 09:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785773476; x=1786378276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O7t2IG/bjYzTOtWYdkDb/FYlzP9IlRZpnBpyzw8LyRI=; b=XL/NQEOV0rj9vrYmMGlvaOmTDrRWIa+SNVPQlL0GVoaje0WvVryzqdu+dTjfYYRVQs JcCEeaWkKjm8pGS5gvtrYMUxzGK6/PpOYy621+9w4Q/qhwbMZkV5NqQwO/UA5r0fQGF0 3thbCEuADL3LY2UiDRuYN8r/hvuFvZIuVSQsprqL5CYC/uRRBgDpqPr48ItYoRDJgYLr +vHxL2nRAeCLDwvuk2/hnOWtuB5nUG76EtP+ciWA//h0zSLtVDFmtN7eMtLfXPqL72Vf SaTO0mC8x1In31XxkgPb4Hh6qNSZeHCpcQ6KbZRr9faoo/oVUu8bOuIvd2L3j0zpV4te 1j5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785773476; x=1786378276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=O7t2IG/bjYzTOtWYdkDb/FYlzP9IlRZpnBpyzw8LyRI=; b=j+tiQoIJC+P1fWHcEl2cBFAmzWtzny0ZJtlSZ+PCiaiUOdVJcdu1UIm7v7iNCRicM9 Rel17NusESLaLIUOpoA1hrx/leFevhGcVJIbnr4PTHMyEx9kuuzdmmaisYNCUPANB8AI 0zgTMUwQttl1piGqHRDaejPX2bVC+8ub7alYFf9Y+FWZQdjkL6DNux+eHNlPTB9IFbQ0 h5f2bZNtvHBHtWCPuohXhOy3yKiIhLhtZeC95trwPtbOLkMrB4LNJgs0b10abPQLlvEX EXjpLIgswKRWNOUrbQzqZ9QECjv9Up3YgQ0q2spVOKoBBud1dj2LNuZxHY91qnLVkQsE 2Xlg== X-Forwarded-Encrypted: i=1; AHgh+RoW660sJf6nhl7FchgaB24npvr3G7IpLbnG4l5kiUvJTtdew+I7jiP+3/6hu5o700GFRWlcN20DwTAkVFk=@vger.kernel.org X-Gm-Message-State: AOJu0YxZe3qxPDZK9oSIBGb31VfbfgC6cHWZGiF2U35i7sDCVr/5HB5a G2zuBmGXVq7JQU62aC7myIOMH9JJ6WbbUAlrdbrY52NIpfJym+4MS2YA X-Gm-Gg: AR+sD13KZqaiAUMOMxRl5kTXenlDu4D253+Jkg4Z2LOeEQq4jHmDqBKP9gvIzJghzFR bIs9N4aB2ovs+XnP19q4OZep/WDnt5Gp+2QiXfmASrgp+NtjJYz8pWYEhF92UojCbG2muNzdACw YMK5oXwfpwpa2gZi52sSNRZZRZZK+39VHGbhYjRmsa2LnHFdLYhAwHtGkYdyQMNXAnUBkULx4YV F6EAbXWvxtg26abBXhk+PcNs5Mm9CMiuFQPQJOSMyZloeaYf23I6JZip3PnY7OvT0KPGmvJ31L9 OspCkw13KsnnMqy4fj58VzSlKDi+18mn0cWD/gZ12ijHGEN8sRwXudryFhVXkqFmYsJMm4kHg6k L3927VZcJjYP5Scra2Lxxe+PyKUD7QAU/WC8atK4aP/V9p6CMe67nqKaAcrAW3fWYRtD+GUwvX2 c+acpXgaTbkbwnGZj1rLWsTRdKAYgFEx3i5DaL/MrO354f2CGKj08jW3nuc9jEt+BCsLEI+C+e1 clszrNMA+SuSjdUww38FKOZvLzRHSzv59NZBOwZW5wQLwA4WtkU3h5MlDfOUoVBsVA4JcfjLQ+5 cmfQ6nwDXe/lk2Neo8jtLgj2/ILI2c6OZEHTFOVvUA6GMmHJ10wOBjDM23ASOfXLUACg5ViHwqk 6Koi1PGIZceWyGeS3x+cxvHk/tOkHLnkHSyDw56m8fWGuVcCKTE+BbkSJDPBZAoqnUGh0VBy00N aAtA== X-Received: by 2002:a05:600c:6d03:b0:495:7a23:1eee with SMTP id 5b1f17b1804b1-4980c674f32mr180465495e9.12.1785773475697; Mon, 03 Aug 2026 09:11:15 -0700 (PDT) Received: from jernej-laptop (APN-122-100-117-gprs.simobil.net. [46.122.100.117]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49949fc2da2sm3363735e9.3.2026.08.03.09.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 09:11:15 -0700 (PDT) From: Jernej Skrabec To: wens@kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, samuel@sholland.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH 02/13] drm/sun4i: vi scaler: Fix coefficient selection Date: Mon, 3 Aug 2026 18:10:40 +0200 Message-ID: <263a4a41442a3c8b072b170256b72658f1b90802.1785772659.git.jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, vertical coefficients are selected based on horizontal scaling, which is wrong. Additionally, chroma coefficients should be selected based on format subsampling. Fix all that. Fixes: b862a648de3b ("drm/sun4i: Add support for HW scaling to DE2") Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_vi_scaler.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c b/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c index 3dec4eeb1ba2..d4412a62c2f0 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_scaler.c @@ -894,20 +894,26 @@ static void sun8i_vi_scaler_set_coeff(struct regmap *map, u32 base, lan3coefftab32_left[offset + i]); regmap_write(map, SUN8I_SCALER_VSU_YHCOEFF1(base, i), lan3coefftab32_right[offset + i]); + } + offset = sun8i_vi_scaler_coef_index(vstep) * + SUN8I_VI_SCALER_COEFF_COUNT; + for (i = 0; i < SUN8I_VI_SCALER_COEFF_COUNT; i++) + regmap_write(map, SUN8I_SCALER_VSU_YVCOEFF(base, i), + lan2coefftab32[offset + i]); + + offset = sun8i_vi_scaler_coef_index(hstep / format->hsub) * + SUN8I_VI_SCALER_COEFF_COUNT; + for (i = 0; i < SUN8I_VI_SCALER_COEFF_COUNT; i++) { regmap_write(map, SUN8I_SCALER_VSU_CHCOEFF0(base, i), ch_left[offset + i]); regmap_write(map, SUN8I_SCALER_VSU_CHCOEFF1(base, i), ch_right[offset + i]); } - - offset = sun8i_vi_scaler_coef_index(hstep) * + offset = sun8i_vi_scaler_coef_index(vstep / format->vsub) * SUN8I_VI_SCALER_COEFF_COUNT; - for (i = 0; i < SUN8I_VI_SCALER_COEFF_COUNT; i++) { - regmap_write(map, SUN8I_SCALER_VSU_YVCOEFF(base, i), - lan2coefftab32[offset + i]); + for (i = 0; i < SUN8I_VI_SCALER_COEFF_COUNT; i++) regmap_write(map, SUN8I_SCALER_VSU_CVCOEFF(base, i), cy[offset + i]); - } } void sun8i_vi_scaler_enable(struct sun8i_layer *layer, bool enable) -- 2.43.0