From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4248939B945 for ; Wed, 4 Mar 2026 11:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622684; cv=none; b=psuZG7NPOreVbkFOSvBF6dOd2PPj771QX+0UCswHgmUPozT6m2SodNYeP2+UonTbuVggLZe30+QqhZnyBnIxVFD7ql/6AmhafiI3NqpIAwfNwOirdhYJXm8qAPzZDziEhbrDFgYj/B7PCP/2kd5ZMIbKZ8qmnERoxHb73lhyT3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622684; c=relaxed/simple; bh=JIuIKTH+GzYh8O8NqAoxb+Doi8Ewuu7b9VzXx/kXQ0Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hwsqsDE4SgYD6acrIe+QJbSV3PRfeJndUUuWEU08wpXmDubYd4ewzNS7FW4kEmRtEF5KoGrl+pJfSMETpeI7u2FnUAG18vZRDEoTxe9lg05f5D9xSuCgAOIOkIypB5Hwcgy2fUokD8so1PiCUmVHtmb0VPc3OY/yib1hVnJJdUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=je1u1I/1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SljtjOOA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="je1u1I/1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SljtjOOA" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245Sc34957475 for ; Wed, 4 Mar 2026 11:11:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yhiCehhF6KyRk1DM1/ckSVrTa7WGu4u+Er1d5fBuqes=; b=je1u1I/1fY9eKfWw mXgbU5Np/+fDawyu9yI/dnCPWwQoU34RLV3BygwZoRjVlBstRQ1DKtLtvwJtw1K6 FOylK+OdRIJA2eroWmB4I1ZP9sohZ11rvQCl0WYeHciAAiMeOgQTCWChl9kw04aR QgChgZ6p9pLp6JTHaCPOM2hJMxvt2dhdtfjWpBR6rjSm65Gbtt1e7DK1MjX88xP1 djwAtOS0edvusk57FaXTWqf+6YiGAc4NZOJEmTigYbn13O7ogCwl/QTFZ5TPvQ6T ciRThTtn/sRnEf9XL9lJTOJpDc3W4lZzcmD8CKZfcn26BxxyxpnAVOvFIvrVqDWK zd7kPQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp6qgam4d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 11:11:22 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb3ad1b81aso1117385a.2 for ; Wed, 04 Mar 2026 03:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772622682; x=1773227482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yhiCehhF6KyRk1DM1/ckSVrTa7WGu4u+Er1d5fBuqes=; b=SljtjOOAK3SJlxEQHOu3mGKxcW0SubJ7UojKhmwueydDpqUIYHr3MgLnckBV46rZ3d JgKU8kqnsx7cB/EtURmjk9sFz7Vdnw3+jwxrKkTTcpNkR8n82/bpd5JYX9NWpdOEgY2e Ehq13KUdVVv0DHIFPv4nX6sJF2RDegupRhpM3taU1mPQyXCvYlooSVidfx9johd1c2aJ 0aOgcVONxVqfcu2Coihwr8IfBCoLrnc6ZICF/dwcqBrvD/fsBH13QYGNOZgRMatpx8Y/ 7SwaN/I+terS+JCMc5UKPDweMo3HjgnDV6BkOKC7GVaPYhncH3PMSsMJKva2JxAqftzO crDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772622682; x=1773227482; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yhiCehhF6KyRk1DM1/ckSVrTa7WGu4u+Er1d5fBuqes=; b=w0Bx1jWQD0jzUOTmHKuD6MSBUA4h51GyFeL8f7zTxbgbsaZueLklOXpJm7CwP6Clbp mqcMGpnzUPngMgATCxLS+eZYSB4pKMWozijLutH1mvBQRk8czhy056DojiUKleLMDPxT Tt88P0i1UpnzUXDaz58PC7zlj2Pd8TVPdpCd413UEhXaQ66SVsV2zLOD7lrekW/Z6ytj xQ2ZFAzSm2miEAAi90DbSgdGk3bSzlot9FQYYhAs1Low4aLuD0pzz7/GN/J+lqh97+gS UWkNm2DdKjgBAl4N0qznrVF/MjCs6e4D2syBfjcLVBqzWO5+SMPLCKQWyg0vkien13NX fswQ== X-Forwarded-Encrypted: i=1; AJvYcCUv9iuBNb1suyru3WeTOtGGHfHZGMjy4/H2/BsZdShVi0nZU9uiYlbVoJVpISewow6ja4jVNZZt4VOcEJE=@vger.kernel.org X-Gm-Message-State: AOJu0YysrSNvBSAi4nwEYCzoASUHmHmjEdj4atYXnDrgX2OF5s2BI4Y5 3XOKWK+zfKgd1OPnIk8CwvaKjbww8qtJz4N3aUH3576uqofM8tSL5um1PKDRQ66e5qQdQHFCQOz LjQCAMH6uEooFFjMjBNSY48ikSFu2hDqUku7e8OVoZyuQ2Dm9YLtfSliuQfChuRRg4oA= X-Gm-Gg: ATEYQzzVTJyLpY999BKY3t6B69rIidgRmiyzGWJVVOItS3UQwT43vdCkgSmp4S0jaVs OjnEwhlvuAjUdgZI2fNvedErQ0nFb/ElSFF3nQPILS9t3FpgOMMtlRCx58/eEU9IzOgPBxru3ot zKUzD2GthuI6qvBMxtYQ0VjZQCOPdkQEyBxgH1inSAEeOangz0tWEEQYyv8agNv4lgOuqNrwHGd c76SoOvAel8/lmIy2w+g9oIhzyNOyQXKVvuCDn/a+YQZTSXeXblcyrXxUpcPWXK5pXKX5+B+NFD OIw7TPXMh9nB2qPVf+T0JaofGbfI/02tz0UNbIWh3b0g6DK8zPmUJGMeWMfKZSudW0azgBL4PpL 57k1Rub+1PmMPD/iL/ki/ngK3ola9x1EWx9fI8Tsu+Yx4v9gD X-Received: by 2002:a05:620a:1aa1:b0:8cb:4d64:e993 with SMTP id af79cd13be357-8cd5aef76a9mr181362985a.26.1772622681669; Wed, 04 Mar 2026 03:11:21 -0800 (PST) X-Received: by 2002:a05:620a:1aa1:b0:8cb:4d64:e993 with SMTP id af79cd13be357-8cd5aef76a9mr181360085a.26.1772622681103; Wed, 04 Mar 2026 03:11:21 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4851ad25a17sm7990115e9.29.2026.03.04.03.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 03:11:20 -0800 (PST) Message-ID: <263d4c1a-caa8-4870-b95b-fde7a11d2a6d@oss.qualcomm.com> Date: Wed, 4 Mar 2026 11:11:19 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/14] ASoC: qcom: qdapm-lpass-dai: correct the error message To: Konrad Dybcio , broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-12-srinivas.kandagatla@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA4NyBTYWx0ZWRfXwe4WZeRlcOzJ iyeGQ5KMR2yYSW6AVa3OTyw6U/l8RmAw70o424g/RmDKUDPnZnyJC9k2yG2nJObUxe7GiqKWOjf k2EsSdd1Y+M7r9yF7DhAvWOhmno66NBRL48yFXGEjHlmYnrIFjz4iHqvwkAY5HSDbFhXCAPSKNz v9eYs/tFwQBk5EhpdTNUxd+DFNqLoUxOu4HgJFuwHevLXjFHdG8KmnxX3zar6He7UjQmRQk6HvM 80+GArVVP3e94vopBZxPEPlxeesMNOxGeIRvhN1bYQXy3pFL3TrZTDn5zKIl9lemUXNnTuUzZ5b hJerP3/z1Q++48hnhr792jsheMk4tIX2/IBG+cwBM2bejnLVvkMZ5dyrZ/GdZUL6vrNG/IEd+Ko IhbYU+p5exSES4zVtyKp2vP5n8eIpsfytZQ0x81hdmJS8aI6wCy0UvsX1aeP1gWFg9JkJMyVnAX EnKz9E7U2Jljhdn9acA== X-Authority-Analysis: v=2.4 cv=UJ3Q3Sfy c=1 sm=1 tr=0 ts=69a8135a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=D-i4kdfbrcmCuYzmauAA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: exUWA3Cluy2xpO6pBntcmLfu8pcitY1w X-Proofpoint-GUID: exUWA3Cluy2xpO6pBntcmLfu8pcitY1w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040087 On 2/24/26 10:12 AM, Konrad Dybcio wrote: > On 2/23/26 7:07 PM, Srinivas Kandagatla wrote: >> Fix the error message to reflect the actual graph stop error >> instead of graph close error. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> index f68d4b4974f3..fc246485e326 100644 >> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> @@ -150,7 +150,7 @@ static void q6apm_lpass_dai_shutdown(struct snd_pcm_substream *substream, struct >> rc = q6apm_graph_stop(dai_data->graph[dai->id]); >> dai_data->is_port_started[dai->id] = false; >> if (rc < 0) >> - dev_err(dai->dev, "fail to close APM port (%d)\n", rc); >> + dev_err(dai->dev, "fail to stop APM port (%d)\n", rc); > > Might also make it "failed" while at it? > Yep --srini > Konrad