From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FBDC05027 for ; Thu, 26 Jan 2023 11:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237262AbjAZLfM (ORCPT ); Thu, 26 Jan 2023 06:35:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237265AbjAZLfJ (ORCPT ); Thu, 26 Jan 2023 06:35:09 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AF5C3A876 for ; Thu, 26 Jan 2023 03:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674732859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vQe5NpZwYsKo7kAgmlBPvHS4P0xn6hUuxnEkAKO3Voc=; b=h9S7lCfgAniY/cN3MGiUkrTKJYbCUyfauysGvRLekb10m6lv0KkED64Loxas89nwcjShza uDovDW7mmzqvYKQ0lERDBf+c/4xXl1SEQo5w2xjeOP3nw7HJNGE/m+6LodyPG8fi1eUmL3 gwD+AdI0P9bcG6egIi0U2f+6l/Yhnn0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-YQTcYeUeMWCzoABBoC_j_Q-1; Thu, 26 Jan 2023 06:34:14 -0500 X-MC-Unique: YQTcYeUeMWCzoABBoC_j_Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A3F2E185A78B; Thu, 26 Jan 2023 11:34:13 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EF24492C14; Thu, 26 Jan 2023 11:34:11 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , David Hildenbrand , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2642147.1674732850.1@warthog.procyon.org.uk> Date: Thu, 26 Jan 2023 11:34:10 +0000 Message-ID: <2642148.1674732850@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Hildenbrand wrote: > > Signed-off-by: David Howells > > Reviewed-by: Christoph Hellwig > > Reviewed-by: John Hubbard > > cc: Al Viro > > cc: Jens Axboe > > cc: Jan Kara > > cc: Matthew Wilcox > > cc: Logan Gunthorpe > > cc: linux-block@vger.kernel.org > > --- > > Oh, and I agree with a previous comment that this patch should also hold a > Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as > the author via "From:". I think that was actually in reference to patch 3, but yes - and possibly a Co-developed-by tag. Christoph? David