From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550FEC433E0 for ; Fri, 7 Aug 2020 17:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 337E520748 for ; Fri, 7 Aug 2020 17:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbgHGRUT (ORCPT ); Fri, 7 Aug 2020 13:20:19 -0400 Received: from out28-99.mail.aliyun.com ([115.124.28.99]:41432 "EHLO out28-99.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbgHGRUT (ORCPT ); Fri, 7 Aug 2020 13:20:19 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07436287|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.105489-0.000923118-0.893588;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03307;MF=zhouyanjie@wanyeetech.com;NM=1;PH=DS;RN=12;RT=12;SR=0;TI=SMTPD_---.IE69Oej_1596820811; Received: from 192.168.10.205(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.IE69Oej_1596820811) by smtp.aliyun-inc.com(10.147.44.129); Sat, 08 Aug 2020 01:20:12 +0800 Subject: Re: [PATCH 00/13] MIPS: Convert Ingenic to a generic board To: Paul Cercueil Cc: Thomas Bogendoerfer , Paul Burton , Krzysztof Kozlowski , od@zcrc.me, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, =?UTF-8?B?5ryG6bmP5oyv?= , dongsheng.qiu@ingenic.com, rick.tyliu@ingenic.com, yanfei.li@ingenic.com, xuwanhao@wanyeetech.com References: <20200803170124.231110-1-paul@crapouillou.net> From: Zhou Yanjie Message-ID: <264327c8-a8c2-407f-5137-22de2b01041e@wanyeetech.com> Date: Sat, 8 Aug 2020 01:20:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, 在 2020/8/8 上午12:45, Paul Cercueil 写道: > Hi Zhou, > > Le sam. 8 août 2020 à 0:23, Zhou Yanjie a > écrit : >> Hi Paul, >> >> I'm not too sure if remove "cpu-feature-overrides.h" will cause some >> problems for X2000, because according to my current test on X2000, I >> found that it is somewhat different from the SoCs using XBurst1 CPU >> core, with the kernel source code provided by Ingenic, for example, >> we must configure "#define cpu_has_tlbinv 1" in >> "cpu-feature-overrides.h" to make the X2000 work normally, otherwise >> the kernel will get stuck. And X2000's interrupt controller has also >> been redesigned. If these differences make it impossible to share >> code, should we set a subdirectory of "xburst" and "xburst2" in >> "arch/mips/ingenic"? (I am just worried about this situation, so far >> I have not been able to successfully run the mainline kernel on X2000). > > The is kind of a hack, to hardcode settings > in case the CPU is not properly detected. The cpu-probe.c should be > able to auto-detect these settings, including the inverted TLB that > the X2000 has, reading from the CPU config registers ("TLB INV" info > should be in config4). Right now cpu_probe_ingenic() doesn't read > config4 (not present on older SoCs) but that's trivial to add. > > As for your other question, I don't see any reason why we wouldn't be > able to support the X2000 aside the others in a generic kernel, so > don't worry :) > OK, this is good news for me. > Cheers, > -Paul > >> >> I have added some related engineers from Ingenic to CC >> >> Thanks and best regards! >> >> 在 2020/8/4 上午1:01, Paul Cercueil 写道: >>> Hi Thomas & list, >>> >>> Here is a set of patches for 5.10 (no rush) to move Ingenic support >>> from >>> arch/mips/jz4740/ to arch/mips/generic/. >>> >>> There are some Kconfig changes that I think should be reviewed in >>> detail >>> to avoid breakages elsewhere. The idea behind these changes is to allow >>> the Ingenic "generic" code to be built in a non-generic kernel, since >>> generic kernels bring lots of dependencies which result in a +7% size >>> increase. >>> >>> Support for booting the generic kernel with a built-in and/or appended >>> devicetree, as well as support for compressed (vmlinuz) kernels, has >>> been added as well. >>> >>> Cheers, >>> -Paul >>> >>> Paul Cercueil (13): >>>    MIPS: cpu-probe: Set Ingenic's writecombine to _CACHE_CACHABLE_WA >>>    MIPS: cpu-probe: Mark XBurst CPU as having vtagged caches >>>    MIPS: cpu-probe: ingenic: Fix broken BUG_ON >>>    MIPS: Kconfig: add MIPS_GENERIC_KERNEL symbol >>>    MIPS: machine: Add get_system_type callback >>>    MIPS: generic: Call the machine's .get_system_type callback if >>>      provided >>>    MIPS: generic: Support booting with built-in or appended DTB >>>    MIPS: generic: Add support for zboot >>>    MIPS: generic: Increase NR_IRQS to 256 >>>    MIPS: generic: Add support for Ingenic SoCs >>>    MIPS: jz4740: Drop folder >>>    MIPS: configs: Regenerate configs of Ingenic boards >>>    MAINTAINERS: Update paths to Ingenic platform code >>> >>>   MAINTAINERS                                   |   4 +- >>>   arch/mips/Kbuild.platforms                    |   1 - >>>   arch/mips/Kconfig                             |  43 ++++-- >>>   arch/mips/configs/ci20_defconfig              |   4 +- >>>   arch/mips/configs/cu1000-neo_defconfig        |  16 +- >>>   arch/mips/configs/gcw0_defconfig              |   2 +- >>>   arch/mips/configs/qi_lb60_defconfig           |   5 +- >>>   arch/mips/configs/rs90_defconfig              |   4 +- >>>   arch/mips/generic/Kconfig                     |   8 +- >>>   arch/mips/generic/Makefile                    |   2 +- >>>   arch/mips/generic/Platform                    |   1 + >>>   arch/mips/generic/board-ingenic.c             | 108 +++++++++++++ >>>   arch/mips/generic/init.c                      |  28 +++- >>>   arch/mips/generic/proc.c                      |  25 --- >>>   arch/mips/include/asm/mach-generic/irq.h      |   2 +- >>>   .../asm/mach-jz4740/cpu-feature-overrides.h   |  50 ------ >>>   arch/mips/include/asm/mach-jz4740/irq.h       |  13 -- >>>   arch/mips/include/asm/machine.h               |   1 + >>>   arch/mips/include/asm/pgtable-bits.h          |   5 - >>>   arch/mips/{jz4740 => ingenic}/Kconfig         |  16 +- >>>   arch/mips/jz4740/Makefile                     |   9 -- >>>   arch/mips/jz4740/Platform                     |   3 - >>>   arch/mips/jz4740/setup.c                      | 145 >>> ------------------ >>>   arch/mips/kernel/cpu-probe.c                  |   8 +- >>>   24 files changed, 198 insertions(+), 305 deletions(-) >>>   create mode 100644 arch/mips/generic/board-ingenic.c >>>   delete mode 100644 arch/mips/generic/proc.c >>>   delete mode 100644 >>> arch/mips/include/asm/mach-jz4740/cpu-feature-overrides.h >>>   delete mode 100644 arch/mips/include/asm/mach-jz4740/irq.h >>>   rename arch/mips/{jz4740 => ingenic}/Kconfig (91%) >>>   delete mode 100644 arch/mips/jz4740/Makefile >>>   delete mode 100644 arch/mips/jz4740/Platform >>>   delete mode 100644 arch/mips/jz4740/setup.c >>> >