From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB56C432BE for ; Sat, 21 Aug 2021 06:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23114611EE for ; Sat, 21 Aug 2021 06:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232607AbhHUGjK (ORCPT ); Sat, 21 Aug 2021 02:39:10 -0400 Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:60072 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230375AbhHUGjI (ORCPT ); Sat, 21 Aug 2021 02:39:08 -0400 Received: from omf06.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 30C2E2BC08; Sat, 21 Aug 2021 06:38:28 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id A72232448BB; Sat, 21 Aug 2021 06:38:26 +0000 (UTC) Message-ID: <26432fc6c0afbd2a17619bf17c25d77dfbd6ba35.camel@perches.com> Subject: Re: [PATCH] rsi: make array fsm_state static const, makes object smaller From: Joe Perches To: Colin King , Amitkumar Karwar , Siva Rebbagondla , Kalle Valo , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 20 Aug 2021 23:38:25 -0700 In-Reply-To: <20210819125018.8577-1-colin.king@canonical.com> References: <20210819125018.8577-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: A72232448BB X-Stat-Signature: 9jyqhky7owqidfg78pank9cf5x9si1eb X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX194m+IktJXozDKaIBjkIauE3xQZZLgErZ8= X-HE-Tag: 1629527906-454354 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2021-08-19 at 13:50 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate the array fsm_state on the stack but instead it > static const. Makes the object code smaller by 154 bytes: [] > diff --git a/drivers/net/wireless/rsi/rsi_91x_debugfs.c b/drivers/net/wireless/rsi/rsi_91x_debugfs.c [] > @@ -117,7 +117,7 @@ static int rsi_stats_read(struct seq_file *seq, void *data) >  { >   struct rsi_common *common = seq->private; > > - unsigned char fsm_state[][32] = { > + static const unsigned char fsm_state[][32] = { why not the even smaller with a defconfig static const char * const fsm_state[] = { >   "FSM_FW_NOT_LOADED", >   "FSM_CARD_NOT_READY", >   "FSM_COMMON_DEV_PARAMS_SENT",