From: liulongfang <liulongfang@huawei.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
<gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yisen.zhuang@huawei.com>
Subject: Re: [PATCH] xhci: print warning when HCE was set
Date: Sat, 24 Sep 2022 10:35:33 +0800 [thread overview]
Message-ID: <2648444c-2f2a-4d9b-8545-6677663adcf0@huawei.com> (raw)
In-Reply-To: <6b5a45f1-caf3-4259-77da-e36788f5b8a9@linux.intel.com>
On 2022/9/22 21:01, Mathias Nyman Wrote:
> Hi
>
> On 15.9.2022 4.11, Longfang Liu wrote:
>> When HCE(Host Controller Error) is set, it means that the xhci hardware
>> controller has an error at this time, but the current xhci driver
>> software does not log this event.
>>
>> By adding an HCE event detection in the xhci interrupt processing
>> interface, a warning log is output to the system, which is convenient
>> for system device status tracking.
>>
>
> xHC should cease all activity when it sets HCE, and is probably not
> generating interrupts anymore.
>
> Would probably be more useful to check for HCE at timeouts than in the
> interrupt handler.
>
Which function of the driver code is this timeout in?
> If this is something seen on actual hardware then it makes sense to add it.
>
This HCE error is sure to report an interrupt on the chip we are using.
> Thanks
> -Mathias
> .
>
Thansk,
Longfang.
next prev parent reply other threads:[~2022-09-24 2:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 1:11 Longfang Liu
2022-09-22 13:01 ` Mathias Nyman
2022-09-24 2:35 ` liulongfang [this message]
2022-09-26 7:58 ` Mathias Nyman
2022-10-14 3:12 ` liulongfang
2022-10-14 7:56 ` Mathias Nyman
2022-12-09 6:13 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2648444c-2f2a-4d9b-8545-6677663adcf0@huawei.com \
--to=liulongfang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®