mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yicong Hui <yiconghui@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	skhan@linuxfoundation.org, david.hunter.linux@gmail.com,
	"Michel Dänzer" <michel.daenzer@mailbox.org>
Subject: Re: [RFC PATCH v1 1/2] drm/syncobj: Add DRM_IOCTL_SYNCOBJ_QUERY_ERROR to query fence error status
Date: Tue, 17 Feb 2026 11:35:51 +0000	[thread overview]
Message-ID: <2648bf28-5ac9-462a-899a-2bfa3905dcb5@gmail.com> (raw)
In-Reply-To: <f1100dad-b9ff-4ba2-987c-4d5cb4c1122c@amd.com>

On 2/17/26 10:29 AM, Christian König wrote:
> On 2/13/26 13:08, Yicong Hui wrote:
>> Add DRM_IOCTL_SYNCOBJ_QUERY_ERROR to allow userspace to query the error
>> status of a fence held by a timeline/binary syncobj.
> 
> Not bad for a first try, but quite a bunch of general comments.
> 
> First of all to get that merged you need to point out a Mesa merge request where this interface is actually used in userspace, so that we can look at the full solution.


> My educated guess is that userspace doesn't want to call this IOCTL separately because of performance reasons.
> 
> Instead add some additional flag to DRM_SYNCOBJ_WAIT_FLAGS_* so that the IOCTL aborts the wait and returns an error as soon as it sees any fence with an error.
> 
> Another DRM_SYNCOBJ_QUERY_FLAGS_* is potentially also useful to query the error on a number of drm_syncobjs at the same time.
> 
> But in general since this is not a HW feature the userspace developers need to voice their requirements and explain how they want to have that implemented.
> 
> So adding Michel on CC, I've briefly discussed that topic with him on XDC last year.
> 
> Thanks,
> Christian.


Hi, thank you for the feedback! :D

Shall I just wait for Michel's input on what interface would work best for Mesa?

Thank you!
-Yicong

  reply	other threads:[~2026-02-17 11:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 12:08 [RFC PATCH v1 0/2] Starter task: Querying errors from Yicong Hui
2026-02-13 12:08 ` [RFC PATCH v1 1/2] drm/syncobj: Add DRM_IOCTL_SYNCOBJ_QUERY_ERROR to query fence error status Yicong Hui
2026-02-17 10:29   ` Christian König
2026-02-17 11:35     ` Yicong Hui [this message]
2026-02-17 14:35     ` Michel Dänzer
2026-02-17 14:45       ` Christian König
2026-02-18 14:49         ` Michel Dänzer
2026-02-19  0:15           ` Yicong Hui
2026-02-19  7:31             ` Christian König
2026-02-13 12:08 ` [RFC PATCH v1 2/2] drm/syncobj/doc: Remove starter task from todo list Yicong Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2648bf28-5ac9-462a-899a-2bfa3905dcb5@gmail.com \
    --to=yiconghui@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=david.hunter.linux@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel.daenzer@mailbox.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®