From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD63C433E1 for ; Sat, 25 Jul 2020 08:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 861EB206C1 for ; Sat, 25 Jul 2020 08:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbgGYINS convert rfc822-to-8bit (ORCPT ); Sat, 25 Jul 2020 04:13:18 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:36688 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgGYINR (ORCPT ); Sat, 25 Jul 2020 04:13:17 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id F303D6071A74; Sat, 25 Jul 2020 10:13:14 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mmZdptfRQbs3; Sat, 25 Jul 2020 10:13:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id EC4D26071A7C; Sat, 25 Jul 2020 10:13:12 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7pjzFcqw8NDv; Sat, 25 Jul 2020 10:13:12 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id C40136071A74; Sat, 25 Jul 2020 10:13:12 +0200 (CEST) Date: Sat, 25 Jul 2020 10:13:12 +0200 (CEST) From: Richard Weinberger To: Greg Kroah-Hartman Cc: Wei Yongjun , Miquel Raynal , Vignesh Raghavendra , linux-mtd , linux-kernel , kernel-janitors , Hulk Robot Message-ID: <265316380.171213.1595664792652.JavaMail.zimbra@nod.at> In-Reply-To: <20200725063701.GA1058480@kroah.com> References: <20200725063416.172037-1-weiyongjun1@huawei.com> <20200725063701.GA1058480@kroah.com> Subject: Re: [PATCH -next] mtd: fix missing unlock on error in mtdchar_compat_ioctl() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809) Thread-Topic: fix missing unlock on error in mtdchar_compat_ioctl() Thread-Index: unRYG1XOaa/d55A4orlZmW/yp+6gkg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Greg Kroah-Hartman" > An: "Wei Yongjun" > CC: "Miquel Raynal" , "richard" , "Vignesh Raghavendra" , > "linux-mtd" , "linux-kernel" , "kernel-janitors" > , "Hulk Robot" > Gesendet: Samstag, 25. Juli 2020 08:37:01 > Betreff: Re: [PATCH -next] mtd: fix missing unlock on error in mtdchar_compat_ioctl() > I think Richard already resolved this in his tree, but I could be wrong. Yes, fixed in git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes and should be visible in linux-next very soon. > And nice detection by your bot, that's good to see. Yeah, good to see that such issues are being detected automatically. Thanks, //richard