From: Yang Jihong <yangjihong1@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <irogers@google.com>,
<adrian.hunter@intel.com>, <anshuman.khandual@arm.com>,
<jesussanp@google.com>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 4/4] perf tools: Add printing perf_event_attr config symbol in perf_event_attr__fprintf()
Date: Sun, 25 Jun 2023 09:38:27 +0800 [thread overview]
Message-ID: <2654189b-0804-305a-be06-3234f39f0403@huawei.com> (raw)
In-Reply-To: <CAM9d7cjzzmjQnJUvE2a6bqDao07o9+mSyJH4C4xRq0zEZJwLnQ@mail.gmail.com>
Hello,
On 2023/6/24 13:28, Namhyung Kim wrote:
> Hello,
>
> On Thu, Jun 22, 2023 at 10:46 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>
>> When printing perf_event_attr, always display perf_event_attr config and
>> its symbol to improve the readability of debugging information.
>>
>
> [SNIP]
>> +
>> +#ifdef HAVE_LIBTRACEEVENT
>> +static void __p_config_tracepoint_id(char *buf, size_t size, u64 value)
>> +{
>> + char *str = tracepoint_id_to_name(value);
>
> This makes the python module import test failing due to the
> undefined symbol. I'll fix it by adding a dummy function in
> util/python.c file. But next time, please run `perf test` first
> and make sure you don't break anything.
Thanks for the correction.
Running `perf test` on my environment has only one testcase for python:
19:'import perf' in python: Ok
The result is OK. The possible cause is that some libraries are missing
in my environment. As a result, other Python tests are not executed.
I'll check them first.
Thanks,
Yang
next prev parent reply other threads:[~2023-06-25 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 5:44 [PATCH v5 0/4] perf tools: Add printing perf_event_attr `config` and `id` " Yang Jihong
2023-06-23 5:44 ` [PATCH v5 1/4] perf trace-event-info: Add tracepoint_id_to_name() helper Yang Jihong
2023-06-23 5:44 ` [PATCH v5 2/4] perf tools: Extend PRINT_ATTRf to support printing of members with a value of 0 Yang Jihong
2023-06-23 5:44 ` [PATCH v5 3/4] perf tools: Add printing perf_event_attr type symbol in perf_event_attr__fprintf() Yang Jihong
2023-06-23 5:44 ` [PATCH v5 4/4] perf tools: Add printing perf_event_attr config " Yang Jihong
2023-06-24 5:28 ` Namhyung Kim
2023-06-25 1:38 ` Yang Jihong [this message]
2023-06-24 23:38 ` [PATCH v5 0/4] perf tools: Add printing perf_event_attr `config` and `id` " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2654189b-0804-305a-be06-3234f39f0403@huawei.com \
--to=yangjihong1@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=irogers@google.com \
--cc=jesussanp@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®