From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 3/4] rtc: ds1307: add offset sysfs for mt41txx chips.
Date: Wed, 18 Jul 2018 11:36:57 +0200 [thread overview]
Message-ID: <265d0f74-d1ca-11c3-4157-6c0405ecbcda@micronovasrl.com> (raw)
In-Reply-To: <20180718092216.91053-2-giulio.benetti@micronovasrl.com>
Il 18/07/2018 11:22, Giulio Benetti ha scritto:
> +#define M41TXX_REG_CONTROL 0x07
> +# define M41TXX_BIT_OUT BIT(7)
> +# define M41TXX_BIT_FT BIT(6)
> +# define M41TXX_BIT_CALIB_SIGN BIT(5)
> +# define M41TXX_M_CALIBRATION GENMASK(5, 0)
This must be GENMASK(4, 0) to be 0x1f.
I'm going to send last patchset, sorry everyone for the mess.
Giulio
next prev parent reply other threads:[~2018-07-18 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 9:22 [PATCH v8 2/4] rtc: ds1307: support m41t11 variant Giulio Benetti
2018-07-18 9:22 ` [PATCH v8 3/4] rtc: ds1307: add offset sysfs for mt41txx chips Giulio Benetti
2018-07-18 9:36 ` Giulio Benetti [this message]
2018-07-18 9:22 ` [PATCH v8 4/4] rtc: ds1307: add frequency_test_enable sysfs attribute to check tick on m41txx Giulio Benetti
2018-07-18 9:22 ` [PATCH v8 1/4] rtc: ds1307: fix data pointer to m41t0 Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265d0f74-d1ca-11c3-4157-6c0405ecbcda@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®