From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B4EECE58E for ; Thu, 17 Oct 2019 15:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A32820869 for ; Thu, 17 Oct 2019 15:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="eD+xx+nm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395067AbfJQPsH (ORCPT ); Thu, 17 Oct 2019 11:48:07 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:58480 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732271AbfJQPsG (ORCPT ); Thu, 17 Oct 2019 11:48:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=t/4nriyqxwybxWS8nhC3dQP2EfSOy3yClE/DGRe068o=; b=eD+xx+nm6Z1uXd+bLUaE2KfyD NjBhQu8FqV0bJq7YLOItjTd6TP+fj/AZELYB4E80AgJs3JtLTz5ax2Iju7fDcboVGp6CK0ZNU/QVg Pby/2/Sajej5gnMqdlvOkYpBrC+qElqgKRtBvcyuYtgE20Sgpv3IpqfXeiab2aGKzITomHyWXUOgc gB0wdbJSk6/sKZFfef06+awBH3qh62penrG4+nBC+ZN3TD1lX2aaQI38iD/TNMNVyuqUFxc+YN7xG oxeQjslGXvUfKXCAODn5NFOvjLa7YSfTg6gwD9I+B5FR50K4K4QoR8jrHav0dBusEsQ/e618CxWze ceYFIlzcw==; Received: from [2601:1c0:6280:3f0::9ef4] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL80T-0007tw-0o; Thu, 17 Oct 2019 15:48:05 +0000 Subject: Re: [PATCH] scripts : mksysmap : NM variable missed the value,so fixed To: Bhaskar Chowdhury , yamada.masahiro@socionext.com, michal.lkml@markovi.net Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org References: <20191017102506.22192-1-unixbhaskar@gmail.com> From: Randy Dunlap Message-ID: <265d9be5-217d-3f67-ba94-095efdcf5787@infradead.org> Date: Thu, 17 Oct 2019 08:48:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191017102506.22192-1-unixbhaskar@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/17/19 3:25 AM, Bhaskar Chowdhury wrote: > This patch will provide the missing value for NM variable. > Hi, Does this patch fix some build error that you have encountered? If so, please describe it and how to cause it. > Signed-off-by: Bhaskar Chowdhury > --- > TO all, > Adjusted the subject line, missed in previous one,sorry > > scripts/mksysmap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/mksysmap b/scripts/mksysmap > index a35acc0d0b82..4b2f45c45f14 100755 > --- a/scripts/mksysmap > +++ b/scripts/mksysmap > @@ -40,5 +40,5 @@ > # 'W' or 'w'. __crc_ are 'A' and placed in the middle > # so we just ignore them to let readprofile continue to work. > # (At least sparc64 has __crc_ in the middle). > - > +NM=$(which nm) That's not the POSIX way to do that. It should be NM=$(command -v nm) But why is this needed at all? The top-level Makefile exports the NM variable (and many more) to scripts that it calls. > $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2 > -- > 2.21.0 > -- ~Randy