From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6607B2F0690 for ; Thu, 4 Dec 2025 09:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842329; cv=none; b=fJ6MGfjDXv7eJDtPPfXuKy0gnnba50UlVKPTESaDVSECIwMlGZmFEJp2VspV9SLl80mAiAA+2PDxdAZwPYTQQiXhgT8qDaPuYiIvXGVKrlyybahPF5cWNn1kJP0gcucRnuY4tbwms5d4A/9xuXqiKIIZQ9y+4MTkcG7Ho8LAEas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764842329; c=relaxed/simple; bh=csnYn/zWPBymTxhjOh1IgCfrqGDsenqQm++WZNaPndg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k/bwUU1yQvDl6b9m7gteycaV0tWhdZTbFDTx2UI62ZpOvZ6bG0FwWKimki3a2/GfVnCgxIFlO/3ectsjRIsd256NIFZu957cVKcGvUA5Ol8V0v7pmntE77OAlW7cg+jsfmi05d9vgrGN3jI6cuX0MxwGW9iG1TZEYJLPAvSE8Yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zeh85N6r; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FQ7mYwX7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zeh85N6r"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FQ7mYwX7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764842325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uGMYk1sfGljMrx70XS76pz0+JZldIxvVU7ZbZaIA+pI=; b=Zeh85N6riuMWszORPbar8CgZ3IZVUbwtfGxM96vWGfrbVdeEijs/rcb3zMm9haHO9gdveQ rNXrGvf2mHfYhpcjCMCoP0508fmPPiwWYupXtPyYOQOy5IOP7NCNmQcP7nilBkS7XVzS6o 1Spl4+prTInQgOxT4rZzXNdu+y6HVpE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-qdWzAQMJN662DiOCgO2oIw-1; Thu, 04 Dec 2025 04:58:44 -0500 X-MC-Unique: qdWzAQMJN662DiOCgO2oIw-1 X-Mimecast-MFC-AGG-ID: qdWzAQMJN662DiOCgO2oIw_1764842323 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42b3b5ed793so462568f8f.2 for ; Thu, 04 Dec 2025 01:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764842323; x=1765447123; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uGMYk1sfGljMrx70XS76pz0+JZldIxvVU7ZbZaIA+pI=; b=FQ7mYwX7i15hrAf9WKoQ+EaEvQQ2K39f4HgzopA3IOFyYGGmDsw5agiGp0T2ypYsgY ktktdlZlgU4Z59KaWXOs0cskU3DU3SCqEvKC/WRz9wDuuST/zvcFFhGAaYihRaHYz21C zqlsL4zspmJ0T7sv0WjGElqjJFBgDudMSMXc20Vfw5ozd4JreR9A4rL9sLFZRm48BITe 6SogzoJxd8KYO0Em28IvL425IkZdCa60am0x/m7WrwmU4ADz9dxBs8g35YMSi3BMb9fo KGuD2WrJI+8QWAI+5S/fu5x6ZidqnlD9c0mRsXa4irs6PiCaWBQHPtwb5QV2bWAjeeXk ryvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764842323; x=1765447123; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uGMYk1sfGljMrx70XS76pz0+JZldIxvVU7ZbZaIA+pI=; b=dnD9i4DWsdk5Il19XSQJCK591sOKaUg8uB8EDJb2yAff39YTH1SsH8EfexHMMaPgN/ W2aWyXA5X70p5piiDA+xjcEE9eZLHjwINpwMgqSqmQyubWsYVdHcy66Z8pOI+t0e3F1u LINSPMYHistqvS6tnOqEggrDnyRM6s9W3uUI98FTKONTZLuuKMr6Zum7rFqzfnVcg7EB 2Pm2k5XFLpcTUSwimWZVtH+NvZTJIWKP7mN7Qgpp8g35BQfZf/o/r0EPuSCUYMucwsbL w2BkQsNhuiM9pHw+KbsiX5KDSH+yyh3zoXBC6KOdHCSR03siCl/2NKgQChtUqdXACKtV X0Eg== X-Forwarded-Encrypted: i=1; AJvYcCXRhc4rJb09+CbAheNf2s/Jofmvpqn5R3IbwvJ95Mj/Fv4SkUHJFjdjpN1GPGAjgiypxH70Ajaj3Y1OTQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0l2HngSajLLJzW9dEdr6V5kkd4jzQ7HY5xu96kkdHt3xjDNBX WYLVX3I/pHy0PGj5z353/bY9apMRMK3RO30vBFsi1Gvcex45kqpuXobpNENVPdV3A785BeUmth8 gxK4tEXvPareoZ9J7sP//Rccmgr7H63TUUfWS0bt2/AfdHpUaMY8rfUEw40sitJrqRQ== X-Gm-Gg: ASbGncv/t2u1bSBpuAiUcsPOg1JTGAF6V7g5BUzb/W08dUX1IPjAASqZkHylrGpW/b6 1GGmvth1l1jLBORbhrKPTAthbUPKLaKuzMObfjNiHferbNNCuzrp+n0+asUYOguxV9h4Bvn7vbF 5tAqaYx3Jy3yPmB2YJv9ggzUDzutLHrqh8zXpRH3l77yQHwbquH+eGfENRA33xzgoQoHKBjcSsK GwUKSYPoiADzWYnAy4IP6/JJbx4NeP3p2xjpbtE0W73W2pa60H1DXkeW2210Sl3q/IFhswZ5B2h x3lP6mh0PTCJPwjD8+nHBSHkN9zMBxZWCCuex39odg6KoZEFCvvVYZdjrTvp7YOyMzmPFxTYlPF AqWjMbD1wUCei X-Received: by 2002:a05:6000:2410:b0:42b:3a84:1ee1 with SMTP id ffacd0b85a97d-42f7317dbc9mr5978660f8f.18.1764842322738; Thu, 04 Dec 2025 01:58:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IER0C5ptlDk7jPg7WID0quVbFz2V15FUInT+2qvmmyu5lX8HX6WC9NCtkC3D/YD1+okBxxd+w== X-Received: by 2002:a05:6000:2410:b0:42b:3a84:1ee1 with SMTP id ffacd0b85a97d-42f7317dbc9mr5978625f8f.18.1764842322345; Thu, 04 Dec 2025 01:58:42 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d353f8bsm2297919f8f.43.2025.12.04.01.58.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 01:58:41 -0800 (PST) Message-ID: <26656845-d9d6-4fd2-bfff-99996cf03741@redhat.com> Date: Thu, 4 Dec 2025 10:58:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: stmmac: Fix E2E delay mechanism To: Rohan G Thomas , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Fugang Duan , Kurt Kanzenbach Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251129-ext-ptp-2v-v2-1-d23aca3e694f@altera.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251129-ext-ptp-2v-v2-1-d23aca3e694f@altera.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/29/25 4:07 AM, Rohan G Thomas wrote: > For E2E delay mechanism, "received DELAY_REQ without timestamp" error > messages show up for dwmac v3.70+ and dwxgmac IPs. > > This issue affects socfpga platforms, Agilex7 (dwmac 3.70) and > Agilex5 (dwxgmac). According to the databook, to enable timestamping > for all events, the SNAPTYPSEL bits in the MAC_Timestamp_Control > register must be set to 2'b01, and the TSEVNTENA bit must be cleared > to 0'b0. > > Commit 3cb958027cb8 ("net: stmmac: Fix E2E delay mechanism") already > addresses this problem for all dwmacs above version v4.10. However, > same holds true for v3.70 and above, as well as for dwxgmac. Updates > the check accordingly. > > Fixes: 14f347334bf2 ("net: stmmac: Correctly take timestamp for PTPv2") > Fixes: f2fb6b6275eb ("net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a") > Fixes: 3cb958027cb8 ("net: stmmac: Fix E2E delay mechanism") > Signed-off-by: Rohan G Thomas > --- > v1 -> v2: > - Rebased patch to net tree > - Replace core_type with has_xgmac > - Nit changes in the commit message > - Link: https://lore.kernel.org/all/20251125-ext-ptp-fix-v1-1-83f9f069cb36@altera.com/ Given there is some uncertain WRT the exact oldest version to be used, it would be great to have some 3rd party testing/feedback on this. Let's wait a little more. Thanks, Paolo