From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E27C3E8C5 for ; Fri, 27 Nov 2020 17:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E98AD208B3 for ; Fri, 27 Nov 2020 17:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b="GXpeoeRh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731953AbgK0RGG (ORCPT ); Fri, 27 Nov 2020 12:06:06 -0500 Received: from dvalin.narfation.org ([213.160.73.56]:49680 "EHLO dvalin.narfation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730985AbgK0RGF (ORCPT ); Fri, 27 Nov 2020 12:06:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1606496763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ApdXLLCo2ftbSslD3CiTtwOwkkM/Xi+DO5JZlq3AnXI=; b=GXpeoeRhdKDRv+PJzx+f0ywR4NFkbgICRjEtuZ7IYO3wPR5MkXMn18Bl+jlMGV9zO19Dr0 hVhz8BDkoldZv1+dWcqoicbkhuIbGzEe4n77if8SVI6g8ZiiZdkUpmsO8QvI7HzEDzpnco NGIVdGM6Fp6ZLhmI3kkbplfAjXV/4x8= From: Sven Eckelmann To: ron minnich Cc: linux-mtd@lists.infradead.org, John Audia , Adrian Schmutzler , jstefek@datto.com, Boris Brezillon , Richard Weinberger , Cyrille Pitchen , lkml - Kernel Mailing List , Marek Vasut , Boris Brezillon , Ron Minnich , Brian Norris , David Woodhouse , Sasha Levin Subject: Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Date: Fri, 27 Nov 2020 18:05:55 +0100 Message-ID: <2666350.AiC22s8V5E@sven-edge> In-Reply-To: References: <20200429165347.48909-1-rminnich@google.com> <7171837.EvYhyI6sBW@sven-edge> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1733315.QZUTf85G27"; micalg="pgp-sha512"; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1733315.QZUTf85G27 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: ron minnich Cc: linux-mtd@lists.infradead.org, John Audia , Adrian Schmutzler , jstefek@datto.com, Boris Brezillon , Richard Weinberger , Cyrille Pitchen , lkml - Kernel Mailing List , Marek Vasut , Boris Brezillon , Ron Minnich , Brian Norris , David Woodhouse , Sasha Levin Subject: Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Date: Fri, 27 Nov 2020 18:05:55 +0100 Message-ID: <2666350.AiC22s8V5E@sven-edge> In-Reply-To: References: <20200429165347.48909-1-rminnich@google.com> <7171837.EvYhyI6sBW@sven-edge> On Friday, 27 November 2020 17:32:02 CET ron minnich wrote: > I'm a bit worried about how tricky this starts to get. I'm inclined to > go back to an earlier implementation which used a character that had > not yet been used (iirc I used [] around the PCI ID in a very early > version). What if we used, e.g, a single ! and searched for that? It > need not be !; pick a character. Just something not already in use, as > the ambiguity around which ':' delimits the device has become an > issue, as you show. > > Almost nothing in the original patch would change, save the character > being searched for. By using a character we'd never used, we'd avoid > breaking existing usage. What? Doesn't make any sense to me. The mtdparts shown in the the commit message is as it is. I cannot simply change it because it is in the control of the bootloader - not the linux kernel or me. So I can also not introduce a different character like ! for separating things. KInd regards, Sven --nextPart1733315.QZUTf85G27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAl/BMfQACgkQXYcKB8Em e0ZTIQ//UHqFRKnJ1Uwupj9kBv6+9klmGzPptfBdx8T92GKLoRbmp5VprWR5KByY sKC5q+XdXn7MVfcAZUA8WCwrJBW+yq6FkC8gYdSZkrvm/ZFCsDWXhLwFnmDuAUhJ 103VyP5OnsrKowBYgiGxaV+A/xKRzBMaEuKooTiSk6oUrETXOxKYUl6SGwoOKZ4G faxoMyMFzGdC42SIZIclJqc3Vtg2MGJ6bX+jEJc7NlEFYrGDGKBGfoueYXGV4NUF soqJ7RiftWB/XqtpCsIEKL4viZqMxjkl28pV2UbqrOxsFInvFNpI/Q0uUyXlDV0F EFW3532oNBITOKAY7uBPFxJZMlNscIrD380CUvtNpppAAKyFOkTqhFzbuWrMwwCr 0nCVaOyhageznzkpyZT1AEqx/z3F7xEOx0vBjL4JhTek09cIJp4EP4mGimRujGfK 2BUAYnWYy1+tdBvXVx/mZFZWHb2W+farCUsytJdKH8IiGE5SrwYo2CC2Z+lL8Rut 9jvZRYuozMF0eSo7iDUmAf+jSP35iBvjJGJbNmm9E9b+hQmbYlbBZ+0CPxc087LN L7vh8dV5F8zUf0UAwZPfbRxukvULn5KYXjDlm5VYBGhwhtZFMclCLcBAuk6Ly65M B+Mu56txrHUbWrf1C95ghPfEvM18INnQVrzJzuckQU2V3/MRJ0o= =GJxP -----END PGP SIGNATURE----- --nextPart1733315.QZUTf85G27--