From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932290AbVHKJbV (ORCPT ); Thu, 11 Aug 2005 05:31:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932304AbVHKJbU (ORCPT ); Thu, 11 Aug 2005 05:31:20 -0400 Received: from mx1.redhat.com ([66.187.233.31]:64651 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S932290AbVHKJbU (ORCPT ); Thu, 11 Aug 2005 05:31:20 -0400 From: David Howells In-Reply-To: <200508110823.53593.phillips@arcor.de> References: <200508110823.53593.phillips@arcor.de> <42F57FCA.9040805@yahoo.com.au> <20050808145430.15394c3c.akpm@osdl.org> <200508110812.59986.phillips@arcor.de> To: Daniel Phillips Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , David Howells Subject: Re: [RFC][PATCH] Rename PageChecked as PageMiscFS X-Mailer: MH-E 7.82; nmh 1.0.4; GNU Emacs 22.0.50.4 Date: Thu, 11 Aug 2005 10:31:12 +0100 Message-ID: <26681.1123752672@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Daniel Phillips wrote: > Note: I have not fully audited the NFS-related colliding use of page flags > bit 8, Nor will you be able to until the NFS caching patches are released. > to verify that it really does not escape into VFS or MM from NFS, in fact I > have misgivings about end_page_fs_misc which uses this flag end_page_fs_misc() simply makes use of the same waitqueues as other page flags. This is surely preferable to instituting a whole new table of waitqueues just for this flag. > but has no in-tree users to show how it is used It did have one: fs/afs/. But the patch has been temporarily removed. Look back into, say, 2.6.13-rc2-mm1. > and, hmm, isn't even _GPL. What is up? EXPORT_SYMBOL_GPL() is a bad idea. It should die as it gives the wrong impression. David