From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbdCCDqn convert rfc822-to-8bit (ORCPT ); Thu, 2 Mar 2017 22:46:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49640 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdCCDql (ORCPT ); Thu, 2 Mar 2017 22:46:41 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <148849717388.26285.3477243497908119377.stgit@warthog.procyon.org.uk> References: <148849717388.26285.3477243497908119377.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] rxrpc: Fix potential NULL-pointer exception MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26696.1488497445.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 02 Mar 2017 23:30:45 +0000 Message-ID: <26697.1488497445@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 02 Mar 2017 23:30:47 +0000 (UTC) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > Fix a potential NULL-pointer exception in rxrpc_do_sendmsg(). The call > state check that I added should have gone into the else-body of the > if-statement where we actually have a call to check. > > Found by CoverityScan CID#1414316 ("Dereference after null check"). > > Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and sendmsg/recvmsg") > Reported-by: Colin Ian King > Signed-off-by: David Howells Please ignore this - there's another patch interposed that I haven't sent upstream yet. Will rebase on net/master. David