mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] input: Add a detailed multi-touch finger data report protocol (rev2)
Date: Mon, 27 Apr 2009 18:50:49 -0400	[thread overview]
Message-ID: <266E0723-B689-4472-8A2F-D93FC6819E04@gmail.com> (raw)

Hi Henrik,

On Wed, Jan 28, 2009 at 11:23:49AM +0100, Henrik Rydberg wrote:
> +
> +#define ABS_MT_TOUCH        0x30    /* Diameter of touching circle */
> +#define ABS_MT_TOUCH_MAJOR    0x30    /* Major axis of touching  
> ellipse */

It looks like we are overriding the same event code to trasnmit 2
slightly different kinds of data. I Am concerned that people would get
confused, maybe we should get rid of ABS_MT_TOUCH and either require
drvices always transmit ABS_MT_TOUCH_MAJOR and ABS_MT_TOUCH_MINOR or
document that for curcular objects ABS_MT_TOUCH_MINOR may be omitted.

> +#define ABS_MT_TOUCH_MINOR    0x31    /* Minor axis of touching  
> ellipse */
> +#define ABS_MT_WIDTH        0x32    /* Diameter of approaching  
> circle */
> +#define ABS_MT_WIDTH_MAJOR    0x32    /* Major axis of approaching  
> ellipse */
> +#define ABS_MT_WIDTH_MINOR    0x33    /* Minor axis of approaching  
> ellipse */

Same here...

> +#define ABS_MT_ORIENTATION    0x34    /* Ellipse orientation */
> +#define ABS_MT_POSITION_X    0x35    /* Center X ellipse position */
> +#define ABS_MT_POSITION_Y    0x36    /* Center Y ellipse position */
> +#define ABS_MT_TOOL_TYPE    0x37    /* Type of touching device */
> +#define ABS_MT_BLOB_ID        0x38    /* Group a set of packets as  
> a blob */
> +
> #define ABS_MAX            0x3f
> #define ABS_CNT            (ABS_MAX+1)
>
> @@ -744,6 +758,14 @@ struct input_absinfo {
> #define BUS_ATARI        0x1B
>
> /*
> + * MT_TOOL types
> + */
> +#define MT_TOOL_FINGER        0
> +#define MT_TOOL_PEN        1
> +#define MT_TOOL_MAX        9
> +#define MT_TOOL_CNT        (MT_TOOL_MAX + 1)

MT_TOOL_FINGER/MT_TOOL_PEN are documented values of ABS_MT_TOOL_TYPE, so
I don't understand why we need MT_TOOL_MAX/MT_TOOL_CNT definitions.

Thanks.

-- 
Dmitry

             reply	other threads:[~2009-04-27 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 22:50 Dmitry Torokhov [this message]
2009-04-28  8:00 ` Henrik Rydberg
  -- strict thread matches above, loose matches on Subject: below --
2009-01-28 10:23 [PATCH 0/6] input: resend of pending patches Henrik Rydberg
2009-01-28 10:23 ` [PATCH 1/6] input: bcm5974: Prepare for a new trackpad header type Henrik Rydberg
2009-01-28 10:23   ` [PATCH 2/6] input: bcm5974: Add quad-finger tapping Henrik Rydberg
2009-01-28 10:23     ` [PATCH 3/6] input: bcm5974: Add support for the Macbook 5 (Unibody) Henrik Rydberg
2009-01-28 10:23       ` [PATCH 4/6] input: bcm5974: Augmented debug information Henrik Rydberg
2009-01-28 10:23         ` [PATCH 5/6] input: Allow certain EV_ABS events to bypass all filtering Henrik Rydberg
2009-01-28 10:23           ` [PATCH 6/6] input: Add a detailed multi-touch finger data report protocol (rev2) Henrik Rydberg
2009-01-30  5:54             ` Joon Young Shim
2009-01-30  6:10             ` Joon Young Shim
2009-01-30 13:10               ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=266E0723-B689-4472-8A2F-D93FC6819E04@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®