From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdBBSV5 (ORCPT ); Thu, 2 Feb 2017 13:21:57 -0500 Received: from foss.arm.com ([217.140.101.70]:36552 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbdBBSV4 (ORCPT ); Thu, 2 Feb 2017 13:21:56 -0500 Subject: Re: [PATCH 03/10] arm64: KVM: Save/restore the host SPE state when entering/leaving a VM To: Will Deacon References: <1485540470-11469-1-git-send-email-will.deacon@arm.com> <1485540470-11469-4-git-send-email-will.deacon@arm.com> <3064a7a5-6661-fc22-c5e4-2478e8457035@arm.com> <20170202181800.GM13839@arm.com> Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, kim.phillips@arm.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, tglx@linutronix.de, peterz@infradead.org, alexander.shishkin@linux.intel.com, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <266dbbc5-ae77-a28d-6fd7-cd4ac18b9606@arm.com> Date: Thu, 2 Feb 2017 18:21:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170202181800.GM13839@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/17 18:18, Will Deacon wrote: > On Wed, Feb 01, 2017 at 04:29:50PM +0000, Marc Zyngier wrote: >> On 27/01/17 18:07, Will Deacon wrote: >>> The SPE buffer is virtually addressed, using the page tables of the CPU >>> MMU. Unusually, this means that the EL0/1 page table may be live whilst >>> we're executing at EL2 on non-VHE configurations. When VHE is in use, >>> we can use the same property to profile the guest behind its back. >>> >>> This patch adds the relevant disabling and flushing code to KVM so that >>> the host can make use of SPE without corrupting guest memory, and any >>> attempts by a guest to use SPE will result in a trap. >>> >>> Cc: Marc Zyngier >>> Cc: Alex Bennée >>> Cc: Christoffer Dall >>> Signed-off-by: Will Deacon >>> --- >>> arch/arm64/include/asm/kvm_arm.h | 3 ++ >>> arch/arm64/include/asm/kvm_host.h | 7 ++++- >>> arch/arm64/kvm/debug.c | 6 ++++ >>> arch/arm64/kvm/hyp/debug-sr.c | 66 +++++++++++++++++++++++++++++++++++++-- >>> arch/arm64/kvm/hyp/switch.c | 17 +++++++++- >>> 5 files changed, 95 insertions(+), 4 deletions(-) > > [...] > >> Acked-by: Marc Zyngier > > Thanks! Given that this patch depends on an earlier one in the series > (already queued via arm64) and the rest of the series depends on this > patch, do you mind if I take this via arm64 for 4.11? It applies cleanly > against current -next. Sure, that's fine by me. I don't foresee anything clashing with this patch that we may queue for 4.11. Thanks, M. -- Jazz is not dead. It just smells funny...