From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EF2C04AB4 for ; Sun, 12 May 2019 06:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A667216C4 for ; Sun, 12 May 2019 06:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbfELGz2 (ORCPT ); Sun, 12 May 2019 02:55:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfELGz2 (ORCPT ); Sun, 12 May 2019 02:55:28 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13AAD308A946; Sun, 12 May 2019 06:55:28 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-61.rdu2.redhat.com [10.10.120.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 218C7691BE; Sun, 12 May 2019 06:55:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190511123603.3265-1-colin.king@canonical.com> References: <20190511123603.3265-1-colin.king@canonical.com> To: Colin King Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: remove redundant assignment to variable ret MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26747.1557644126.1@warthog.procyon.org.uk> Date: Sun, 12 May 2019 07:55:26 +0100 Message-ID: <26748.1557644126@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sun, 12 May 2019 06:55:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > The variable ret is being assigned a value however this is never > read and later it is being reassigned to a new value. The assignment > is redundant and hence can be removed. No. > if (ret == 0) { > ret = acl->size; > if (size > 0) { > - ret = -ERANGE; > if (acl->size > size) > return -ERANGE; > memcpy(buffer, acl->data, acl->size); This is the wrong solution. acl and key need releasing, so the return should be a goto. David