mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH] clockevents.c: fix symbol was not declared noise
Date: Sun, 18 Oct 2009 14:25:25 +0800	[thread overview]
Message-ID: <2674af740910172325n2bfeb444i41966fd95fc7951c@mail.gmail.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901E24550@mi8nycmail19.Mi8.com>

On Sat, Oct 17, 2009 at 6:19 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> Include "tick-internal.h" in order to pick up the extern function
> prototype for clockevents_shutdown().  This quiets the following
> spares build noise:
>
>  warning: symbol 'clockevents_shutdown' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>

Looks good.
Reviewed-by: Yong Zhang <yong.zhang0@gmail.com>

Cc'ed some experts.

> ---
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 620b58a..c30ba1f 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -20,6 +20,8 @@
>  #include <linux/sysdev.h>
>  #include <linux/tick.h>
>
> +#include "tick-internal.h"
> +
>  /* The registered clock event devices */
>  static LIST_HEAD(clockevent_devices);
>  static LIST_HEAD(clockevents_released);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2009-10-18  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 22:19 H Hartley Sweeten
2009-10-18  6:25 ` Yong Zhang [this message]
2009-11-18 11:36 ` [tip:timers/core] clockevents: Add missing include to pacify sparse tip-bot for H Hartley Sweeten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2674af740910172325n2bfeb444i41966fd95fc7951c@mail.gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=hartleys@visionengravers.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®