From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B2C7302CD5 for ; Fri, 21 Nov 2025 22:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764858; cv=none; b=eo3mSKLvVaEy+Ybv0KrUoQme//pgCjJOLGj9ZevDddxFxWRKsFvvk9BCUXL872MMH2gThGOgqzZN1JsDGYhj42TnWJGr+dc+AamqdOmI+Vn9bx+qsN5ywQ0gvfT0EPPVcWM3DOqpUTmHGtgRz7YEf9WQcmYl864dGoDHcWZLcgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763764858; c=relaxed/simple; bh=Xtbd/tDrpDJ+fRqhe/V8DDd/AxQSdS2P9J8yChwZUWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mF/G0c/nfiU+wXjfe8c1L1vcw/LPPIn35UwKhjZi9WxIXojGRWc2z/xyuL1fWSagTNRpzykM1zJNWu6Aecqaw2g170a9JxB3esvQAgIQusDsE9H5xXCM0ZGtR6OHGi08j7HQ30vbPuLaip6zhaKM4z6AiC7s+PL3GxufHP363zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=l9m7Jqtj; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="l9m7Jqtj" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-450c65f3510so1064252b6e.2 for ; Fri, 21 Nov 2025 14:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1763764853; x=1764369653; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/9HltdgSop5FEcwGaXa8vPayworSeD5MYQywbM3e3j8=; b=l9m7Jqtj9YGxZgnBP8/4bFwRgTHupwDqB2B72BQLrUV67PPZPIvg+i3quzscwAKhLm mxDYxHpxhsHZPTHOp0GJL1L3CCQ56LYJ6YtrLZvp5ILFFXSvugcSG/22vJe3j6Fmyqv3 6DNAMfHGwkV91jrqLz2w9czmTNkr5/W+gsNMNYzR9Pdd/Y1AFN6TUoer96nXRW5lc+d6 oh+O970OVzzbC5PQu881PaO75gYrB6s/G5TCdKc7aEAzQ5OJFnVYKh74ARC9PxX2ChFy mWPr9i2WIyhzKc8VVOj0vMQFPIOLSOzXOFLmU+UlH6lOJ6WYJtMgdaqH4HG/6GkHLh8F rHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763764853; x=1764369653; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/9HltdgSop5FEcwGaXa8vPayworSeD5MYQywbM3e3j8=; b=OIyO6Qr+7BFP7cR7Cf8WmDazUf1qAb0WpjYPtAHSlpPgFCG2NkiFTXFHgg+o+mkWAX 236eLMTd1GP7gREIfm+yfmfOa6bhhJsb/bkpA2OjxB3OJXrCycLKXZxVc33cAEmohq2f h2OM04+ZdQoEx3RATU+xbiTcfBje3jsAtPRisKng9ED6uGfz3PON7C9k3OitCvyzUfgZ O1NJFQpVEVgxoKdV+dmBJxnVFqT4KBZo2HjDT1+/etcxjCVtY4br2csXEzsipJZazqA/ c9RLHJj9PAKlQpDZ3p1RqafQ+8AgpyGLMYenRUJO5efkjFI+Ogu4P6hE+Zm78xLIvIoK CPug== X-Forwarded-Encrypted: i=1; AJvYcCXUISDZUX7n2J+8pHZGjws75UCs7wCt1SnjVvDunBUoWr06Xl6uqwNYL0yOMeriSAuJcERzsRc7x6Ljbhg=@vger.kernel.org X-Gm-Message-State: AOJu0YytXFTPjHI5m4fprBo9OXrmC7gLu0wqI1oTcEFr22V3kCpyevYG oz3bRhwvfHl3nOi4lgmsykfaZSK/4AlssQucJ5eNlIAStTNE4M/V01UCaGC/6zjGB0Y= X-Gm-Gg: ASbGncvyTypS1svRJdDPOcWFg1KW/ihgqUTJJofH7iSOh++xsuROa+vv3eB6a7A3lbt j7eZJfUqSm67uy/jROMr/Y0zWyajeISswFmdfvvDV//LFHZxMsDvMu7ZqsiNhhKHQzarotTyj47 Q0pAEMbwNUvqvMjINW0NQriUhx779T4z9WK6E224Vu0MTHORJR+SBzp+Uv/zSHMGxlzBo3Hd1Ee U22cu/WZGw61ltrxPNAsSfleHe+CmPm6FHcqN+R5P1mh47f16VTjfCTi5IBo1UcduMTtgy1qAKU M3RDvrhD7wPTGgG7STTiGe3kqXIR0NP/e+WT4KhmAjYGzOhg4BE8BBdsl2No3E26UjSIjXtSMFy y3Fy5XRM7dh3ABATi3iGr/t5WNTidyzvclE6V0JgQtxdSLKYeBCEzsJXdrIbo0AoUVFNeFAvNdv +47UgYTuiVNpHD2h2OIbjbaNL2MtpOue4p2gsE4FbbMqoWQf4H+oOWK+NL5KwT X-Google-Smtp-Source: AGHT+IH/slIetdPjT1yIwsdNKVVzy5MESsn9ZF/43EcVZTNE94DWi1oupV08GRdpE1jhr3gqCvmzvQ== X-Received: by 2002:a05:6808:4fcb:b0:450:390e:61da with SMTP id 5614622812f47-4511294f265mr1829497b6e.5.1763764853687; Fri, 21 Nov 2025 14:40:53 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:e782:93d8:7c2f:f9df? ([2600:8803:e7e4:500:e782:93d8:7c2f:f9df]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450fffbd109sm2075774b6e.17.2025.11.21.14.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Nov 2025 14:40:52 -0800 (PST) Message-ID: <2676d37e-fe3c-4504-8990-fbee0ce8407a@baylibre.com> Date: Fri, 21 Nov 2025 16:40:50 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118 To: Kurt Borja , Krzysztof Kozlowski , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tobias Sperling Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron References: <20251121-ads1x18-v1-0-86db080fc9a4@gmail.com> <20251121-ads1x18-v1-1-86db080fc9a4@gmail.com> <32e76bff-f535-40ce-88e2-7bbf7da87620@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/21/25 2:56 PM, Kurt Borja wrote: > Hi Krzysztof, > > On Fri Nov 21, 2025 at 2:10 PM -05, Krzysztof Kozlowski wrote: >> On 21/11/2025 18:16, Kurt Borja wrote: >>> Add documentation for Texas Instruments ADS1018 and ADS1118 >>> analog-to-digital converters. >>> >>> Signed-off-by: Kurt Borja >> >> You did not test it before sending, so no full review but few nits to >> save you one round of reviews: > > My bad! I will fix the errors. Thanks! > ... >>> + interrupts: >>> + description: DOUT/DRDY (Data Out/Data Ready) line. >>> + maxitems: 1 >>> + >>> + drdy-gpios: >>> + description: >>> + Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows >>> + distinguishing between latched and real DRDY IRQs. >> >> I have feeling that you miss proper handling of IRQs (e.g. active level) >> on your board. > > Can you elaborate? Should I specify active level here? > >> The problem is not about the levels. It is rather that the behavior of the interrupt when disabled/masked is different on different interrupt controllers. On some controllers, if an event happens while disabled/masked, it "remembers" that and will trigger the interrupt as soon as it is enabled even if the condition doesn't exist anymore. Not a great hardware design IMHO, but there is real hardware that does this. I think a better wording would be to leave out "latched" and say that it is needed to be able to distinguish between an interrupt triggered by the DRDY signal vs. an interrupt triggered by SPI data.