From: Milian Wolff <milian.wolff@kdab.com>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Wang Nan <wangnan0@huawei.com>, Jin Yao <yao.jin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kim Phillips <kim.phillips@arm.com>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser
Date: Wed, 28 Jun 2017 11:44:48 +0200 [thread overview]
Message-ID: <26773596.thloZocoZ7@milian-kdab2> (raw)
In-Reply-To: <1498619652-763-1-git-send-email-treeze.taeung@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Wednesday, June 28, 2017 5:14:12 AM CEST Taeung Song wrote:
> Unlike asm code level, the new source code view
> provides a additional viewpoint based on source code level
> for performance analysis.
>
> Of course, current disassembly view can show itself with pieces of source
> code but some users want to check the result of performance analysis
> based on full source code view. So add this view to the annotate TUI
> browser.
>
> Users can switch to the new source code view by a 'S' key
> and additionally support a 't' key toggling total period view.
The 't' key support should be a separate patch, I guess. It also does not
update the column header (it stays at "Percent").
--
Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 3826 bytes --]
next prev parent reply other threads:[~2017-06-28 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 3:14 Taeung Song
2017-06-28 9:44 ` Milian Wolff [this message]
2017-06-28 16:15 ` Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26773596.thloZocoZ7@milian-kdab2 \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome