From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754913AbcEDV5t (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 May 2016 17:57:49 -0400
Received: from cloudserver094114.home.net.pl ([79.96.170.134]:60463 "HELO
	cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1753641AbcEDV5r (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 May 2016 17:57:47 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Eduardo Valentin <edubezval@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Rui Zhang <rui.zhang@intel.com>,
        Linux PM <linux-pm@vger.kernel.org>, Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] drivers: acpi: add CPU id to cooling device type of processor driver
Date: Thu, 05 May 2016 00:00:57 +0200
Message-ID: <2680812.8DqCpBTJz8@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1462398872.14904.29.camel@linux.intel.com>
References: <1462251879-7224-1-git-send-email-edubezval@gmail.com> <CAJZ5v0hPL3Wc1ZKZv-Gqny5cur9+262OCuqVqbQ2US9=gpsX7g@mail.gmail.com> <1462398872.14904.29.camel@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, May 04, 2016 02:54:32 PM Srinivas Pandruvada wrote:
> On Wed, 2016-05-04 at 23:49 +0200, Rafael J. Wysocki wrote:
> > On Tue, May 3, 2016 at 7:04 AM, Eduardo Valentin <edubezval@gmail.com
> > > wrote:
> > > 
> > > Currently, in an ACPI based system, the processor driver registers
> > > one cooling device per processor. However, the cooling device type
> > > is the same for each processor. For example, on a system with four
> > > processors, the sysfs reading of each cooling device would look
> > > like:
> > > ebv@besouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > > Processor
> > > Processor
> > > Processor
> > > Processor
> > > 
> > > which turns out to fine. But, some parts of the thermal code may
> > > use
> > > type to identify participating devices in a thermal zone. Besides,
> > > adding notifications to user space may cause the production of
> > > messages
> > > that may confuse the listener.
> > > 
> > > For this reason, this patch adds the processor ID cooling device
> > > type.
> > > After this change, the cooling device listing in the same previous
> > > example
> > > would look like this:
> > > ebv@besouro ~ $ cat /sys/class/thermal/cooling_device*/type
> > > Processor.0
> > > Processor.1
> > > Processor.2
> > > Processor.3
> > > 
> > > allowing an easier identification of cooling device target.
> > 
> > Is it not going to confuse any user space scripts or similar?
>
> Yes, it will.

In that case the patch cannot be applied.

Thanks,
Rafael