From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755914AbdJLQR4 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 12 Oct 2017 12:17:56 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:39089 "EHLO
        youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753221AbdJLQRw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Oct 2017 12:17:52 -0400
Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs static,
 reduces object code size
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <CGME20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162@epcas2p3.samsung.com>
 <20170919213201.31845-1-colin.king@canonical.com>
 <3245965.OqUEzHD6FT@amdc3058>
From: Colin Ian King <colin.king@canonical.com>
Message-ID: <268158e3-00d6-b9c3-34a4-e8ce8e464276@canonical.com>
Date: Thu, 12 Oct 2017 17:17:49 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <3245965.OqUEzHD6FT@amdc3058>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/10/17 17:17, Bartlomiej Zolnierkiewicz wrote:
> 
> [ added dri-devel ML to cc: ]
> 
> On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate the read-only const array post_divs on the stack,
>> nstead make it static. Makes the object code smaller by 90 bytes:
>>
>> Before:
>>    text	   data	    bss	    dec	    hex	filename
>>   40231	   8584	    896	  49711	   c22f	radeon_base.o
>>
>> After:
>>    text	   data	    bss	    dec	    hex	filename
>>   39914	   8744	    960	  49618	   c1d2	radeon_base.o
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Are these results obtained using the same compiler as the other patches
> (gcc version 7.2.0, x86_64)?

Yes, I forgot to annotate it.

Colin
> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>