mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zheng Qixing <zhengqixing@huaweicloud.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk,
	yukuai3@huawei.com, hch@infradead.org, cgroups@vger.kernel.org,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com, houtao1@huawei.com,
	Zheng Qixing <zhengqixing@huawei.com>
Subject: Re: [PATCH v2 1/3] blk-cgroup: fix race between policy activation and blkg destruction
Date: Thu, 15 Jan 2026 13:32:56 +0800	[thread overview]
Message-ID: <2685a1b2-9c68-4b14-87bc-96c19a0a2e48@huaweicloud.com> (raw)
In-Reply-To: <le5sjny634ffj6piswnkhkh33eq5cbclgysedyjl2bcuijiutf@f3j6ozw7zuuc>

Resend...

blkcg_activate_policy()                blkg_free_workfn()
-------------------                    ------------------
spin_lock(&q->queue_lock)
...
if (!pd) {
     spin_unlock(&q->queue_lock)
     ...
     goto enomem
     }
enomem:
     spin_lock(&q->queue_lock)
     if (pd) {

                        ->pd_free_fn()  // pd freed

        pd->online // uaf
        ...
     }

                        spin_lock(&q->queue_lock)

                        list_del_init(&blkg->q_node)

                        spin_unlock(&q->queue_lock) 


  parent reply	other threads:[~2026-01-15  5:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  6:10 [PATCH v2 0/3] blk-cgroup: cleanup and bugfixs in blk-cgroup Zheng Qixing
2026-01-13  6:10 ` [PATCH v2 1/3] blk-cgroup: fix race between policy activation and blkg destruction Zheng Qixing
2026-01-14 10:40   ` Michal Koutný
2026-01-15  3:27     ` Zheng Qixing
2026-01-15  9:39       ` Michal Koutný
2026-01-15  5:32     ` Zheng Qixing [this message]
2026-01-15  5:19   ` Yu Kuai
2026-01-15  5:44     ` Zheng Qixing
2026-01-13  6:10 ` [PATCH v2 2/3] blk-cgroup: skip dying blkg in blkcg_activate_policy() Zheng Qixing
2026-01-14 10:42   ` Michal Koutný
2026-01-15  5:24   ` Yu Kuai
2026-01-15  9:22     ` Zheng Qixing
2026-01-13  6:10 ` [PATCH v2 3/3] blk-cgroup: factor policy pd teardown loop into helper Zheng Qixing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2685a1b2-9c68-4b14-87bc-96c19a0a2e48@huaweicloud.com \
    --to=zhengqixing@huaweicloud.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=houtao1@huawei.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --cc=zhengqixing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®