From: David Howells <dhowells@redhat.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: dhowells@redhat.com, benh@kernel.crashing.org, joel@jms.id.au,
eajames@linux.vnet.ibm.com, andrew@aj.id.au,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi:fsi-sbefifo: Fix possible concurrency use-after-free bugs in sbefifo_user_release
Date: Wed, 02 Jan 2019 09:34:53 +0000 [thread overview]
Message-ID: <26864.1546421693@warthog.procyon.org.uk> (raw)
In-Reply-To: <20181226135618.12784-1-baijiaju1990@gmail.com>
Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> + mutex_lock(&user->file_lock);
> sbefifo_release_command(user);
> free_page((unsigned long)user->cmd_page);
> + mutex_unlock(&user->file_lock);
It shouldn't be necessary to do the free_page() call inside the locked
section.
David
next prev parent reply other threads:[~2019-01-02 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 13:56 Jia-Ju Bai
2019-01-02 9:34 ` David Howells [this message]
2019-01-03 3:27 ` Benjamin Herrenschmidt
2019-01-03 4:26 ` Benjamin Herrenschmidt
2019-01-04 0:47 ` Benjamin Herrenschmidt
2019-01-04 2:26 ` Jia-Ju Bai
2019-01-04 3:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26864.1546421693@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=andrew@aj.id.au \
--cc=baijiaju1990@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®