From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FA1C761A6 for ; Tue, 4 Apr 2023 17:17:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235921AbjDDRRy (ORCPT ); Tue, 4 Apr 2023 13:17:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235910AbjDDRRr (ORCPT ); Tue, 4 Apr 2023 13:17:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7781449C3 for ; Tue, 4 Apr 2023 10:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680628619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9/qlLB/Y+0maKwWIY7hsMZMlokqBZ5/HAXA6LW4lTOs=; b=ieslbXWYbROfs/lx/6xdE4OnNJBbr3NMx+quuqf/d+Q1EEPlmpO6Pu44PVMfdEZ/+36KQd R+0WtNxRJ+eH4Wj4nV0Fli12TuPuBSjgobiGF7qbj6wDU5Myv9t27vp1QCmLEAQPNz4vIH opqL4aUNlVkqAmi+2YydpsA3pIruFZw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-G6S7IDCqOw2DtHaojdd83w-1; Tue, 04 Apr 2023 13:16:57 -0400 X-MC-Unique: G6S7IDCqOw2DtHaojdd83w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8BA5B857FB7; Tue, 4 Apr 2023 17:16:53 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56604C33187; Tue, 4 Apr 2023 17:16:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <642c5731a7cc5_337e2c208b0@willemb.c.googlers.com.notmuch> References: <642c5731a7cc5_337e2c208b0@willemb.c.googlers.com.notmuch> <642ad8b66acfe_302ae1208e7@willemb.c.googlers.com.notmuch> <64299af9e8861_2d2a20208e6@willemb.c.googlers.com.notmuch> <20230331160914.1608208-1-dhowells@redhat.com> <20230331160914.1608208-16-dhowells@redhat.com> <1818504.1680515446@warthog.procyon.org.uk> <2258798.1680559496@warthog.procyon.org.uk> To: Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 15/55] ip, udp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2688905.1680628610.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 04 Apr 2023 18:16:50 +0100 Message-ID: <2688906.1680628610@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Willem de Bruijn wrote: > > Okay. How about the attached? This seems to work. Just setting "pag= ed" to > > true seems to do the right thing in __ip_append_data() when allocating= / > > setting up the skbuff, and then __ip_splice_pages() is called to add t= he > > pages. > = > If this works, much preferred. Looks great to me. :-) > As said, then __ip_splice_pages() probably no longer needs the > preamble to copy initial header bytes. Sorry, what? It only attaches pages extracted from the iterator. David